From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Parag Warudkar" Subject: Re: [PATCH] e1000: Use deferrable timer for watchdog Date: Wed, 19 Dec 2007 14:39:25 -0500 Message-ID: <82e4877d0712191139k4dbae463icf2a59c8c0104010@mail.gmail.com> References: <47696AC9.90204@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, "Arjan van de Ven" To: "Kok, Auke" Return-path: Received: from ro-out-1112.google.com ([72.14.202.180]:22028 "EHLO ro-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753672AbXLSTj1 (ORCPT ); Wed, 19 Dec 2007 14:39:27 -0500 Received: by ro-out-1112.google.com with SMTP id p4so3991841roc.5 for ; Wed, 19 Dec 2007 11:39:26 -0800 (PST) In-Reply-To: <47696AC9.90204@intel.com> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: On 12/19/07, Kok, Auke wrote: [snip] > I can't possibly see any benefit from this other than that you just add up to a > whole second to the initialization cycle, which is bad. > Well, Ok but it can't be bad - I've been using this patch sometime and haven't seen any problem at all and powertop shows it reduces the wakeups-from-idle. But whatever - no big deal since it already uses round_jiffies(). Parag > > > > Signed-off-by: Parag Warudkar > > > > --- linux-2.6/drivers/net/e1000/e1000_main.c 2007-12-07 > > 10:04:39.000000000 -0500 > > +++ linux-2.6-work/drivers/net/e1000/e1000_main.c 2007-12-18 > > 20:38:38.000000000 -0500 > > @@ -1030,7 +1030,7 @@ > > adapter->tx_fifo_stall_timer.function = &e1000_82547_tx_fifo_stall; > > adapter->tx_fifo_stall_timer.data = (unsigned long) adapter; > > > > - init_timer(&adapter->watchdog_timer); > > + init_timer_deferrable(&adapter->watchdog_timer); > > adapter->watchdog_timer.function = &e1000_watchdog; > > adapter->watchdog_timer.data = (unsigned long) adapter; > > > > -- > > To unsubscribe from this list: send the line "unsubscribe netdev" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > >