From: Florian Weimer <fweimer@bfk.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Hayim Shaul <hayim@iportent.com>, Jeff Garzik <jeff@garzik.org>,
netdev@vger.kernel.org, edward_peng@dlink.com.tw,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.18-rc6 1/2] dllink driver: porting v1.19 to linux 2.6.18-rc6
Date: Thu, 21 Sep 2006 15:29:09 +0200 [thread overview]
Message-ID: <82slilmjq2.fsf@mid.bfk.de> (raw)
In-Reply-To: <1157620795.14882.16.camel@laptopd505.fenrus.org> (Arjan van de Ven's message of "Thu, 07 Sep 2006 11:19:55 +0200")
* Arjan van de Ven:
>> if (irq)
>> spin_lock(&np->tx_lock);
>> else
>> spin_lock_irqsave(&np->tx_lock, flag);
>
> double eeeep
>
> this is wrong to do with in_interrupt() as gating factor!
Well, this is not Hayim fault. It's in 2.6.18 as is.
Unfortunately, the driver does not work very well. Transmitting
frames hangs after a while (quickly to reproduce with ping -f
-s40000). Any suggestions how we could this get working? The cards
used work quite well in older systems despite all the driver bugs, but
current systems with different timings expose them.
--
Florian Weimer <fweimer@bfk.de>
BFK edv-consulting GmbH http://www.bfk.de/
Durlacher Allee 47 tel: +49-721-96201-1
D-76131 Karlsruhe fax: +49-721-96201-99
next prev parent reply other threads:[~2006-09-21 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-07 9:09 [PATCH 2.6.18-rc6 1/2] dllink driver: porting v1.19 to linux 2.6.18-rc6 Hayim Shaul
2006-09-07 9:19 ` Arjan van de Ven
2006-09-07 10:52 ` Francois Romieu
2006-09-10 11:10 ` Hayim Shaul
2006-09-21 13:29 ` Florian Weimer [this message]
2007-09-13 4:00 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82slilmjq2.fsf@mid.bfk.de \
--to=fweimer@bfk.de \
--cc=arjan@infradead.org \
--cc=edward_peng@dlink.com.tw \
--cc=hayim@iportent.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).