From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: David Christensen <drc@linux.vnet.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Magnus Karlsson <magnus.karlsson@intel.com>,
Michal Kubiak <michal.kubiak@intel.com>,
Larysa Zaremba <larysa.zaremba@intel.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Christoph Hellwig <hch@lst.de>, <netdev@vger.kernel.org>,
<intel-wired-lan@lists.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 08/11] iavf: switch to Page Pool
Date: Thu, 25 May 2023 13:08:19 +0200 [thread overview]
Message-ID: <8302be1b-416a-de32-c43b-73bd378f8122@intel.com> (raw)
In-Reply-To: <4c6723df-5d40-2504-fcdc-dfdc2047f92c@linux.vnet.ibm.com>
From: David Christensen <drc@linux.vnet.ibm.com>
Date: Tue, 23 May 2023 15:42:28 -0700
>
>
> On 5/16/23 9:18 AM, Alexander Lobakin wrote:
>> Now that the IAVF driver simply uses dev_alloc_page() + free_page() with
>> no custom recycling logics and one whole page per frame, it can easily
>> be switched to using Page Pool API instead.
>
> Any plans to add page pool fragmentation support (i.e.
> PP_FLAG_PAGE_FRAG) in the future to better support architectures with
> larger page sizes such as 64KB on ppc64le?
Currently no, we resigned from page fragmentation due to the complexity
and restrictions it provides for no benefits on x86_64. But I remember
that pages > 4 Kb exist (I have a couple MIPS boards where I have fun
sometimes and page size is set to 16 Kb there. But still always use 1
page per frame).
By "better support" you mean reducing memory usage or something else?
>
> Dave
Thanks,
Olek
next prev parent reply other threads:[~2023-05-25 11:08 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 16:18 [PATCH net-next 00/11] net: intel: start The Great Code Dedup + Page Pool for iavf Alexander Lobakin
2023-05-16 16:18 ` [PATCH net-next 01/11] net: intel: introduce Intel Ethernet common library Alexander Lobakin
2023-05-16 16:18 ` [PATCH net-next 02/11] iavf: kill "legacy-rx" for good Alexander Lobakin
2023-05-16 16:18 ` [PATCH net-next 03/11] iavf: optimize Rx buffer allocation a bunch Alexander Lobakin
2023-05-16 16:18 ` [PATCH net-next 04/11] iavf: remove page splitting/recycling Alexander Lobakin
2023-05-16 16:18 ` [PATCH net-next 05/11] iavf: always use a full order-0 page Alexander Lobakin
2023-05-16 16:18 ` [PATCH net-next 06/11] net: page_pool: avoid calling no-op externals when possible Alexander Lobakin
2023-05-17 8:14 ` Christoph Hellwig
2023-05-18 13:26 ` Alexander Lobakin
2023-05-18 4:08 ` Jakub Kicinski
2023-05-18 4:54 ` Yunsheng Lin
2023-05-18 13:29 ` Alexander Lobakin
2023-05-18 13:34 ` Alexander Lobakin
2023-05-18 15:02 ` Jakub Kicinski
2023-05-16 16:18 ` [PATCH net-next 07/11] net: page_pool: add DMA-sync-for-CPU inline helpers Alexander Lobakin
2023-05-18 4:12 ` Jakub Kicinski
2023-05-18 7:03 ` Ilias Apalodimas
2023-05-18 13:53 ` Alexander Lobakin
2023-05-18 13:45 ` [Intel-wired-lan] " Alexander Lobakin
2023-05-18 14:56 ` Jakub Kicinski
2023-05-18 15:41 ` Alexander Lobakin
2023-05-18 20:36 ` Jakub Kicinski
2023-05-19 13:56 ` Alexander Lobakin
2023-05-19 20:45 ` Jakub Kicinski
2023-05-22 13:48 ` Alexander Lobakin
2023-05-22 15:27 ` Magnus Karlsson
2023-05-18 4:19 ` Jakub Kicinski
2023-05-16 16:18 ` [PATCH net-next 08/11] iavf: switch to Page Pool Alexander Lobakin
2023-05-23 22:42 ` David Christensen
2023-05-25 11:08 ` Alexander Lobakin [this message]
2023-05-31 20:18 ` David Christensen
2023-06-02 13:25 ` Alexander Lobakin
2023-05-16 16:18 ` [PATCH net-next 09/11] libie: add common queue stats Alexander Lobakin
2023-05-16 16:18 ` [PATCH net-next 10/11] libie: add per-queue Page Pool stats Alexander Lobakin
2023-05-18 4:19 ` Jakub Kicinski
2023-05-18 13:47 ` Alexander Lobakin
2023-05-22 15:05 ` [Intel-wired-lan] " Paul Menzel
2023-05-22 15:32 ` Alexander Lobakin
2023-05-16 16:18 ` [PATCH net-next 11/11] iavf: switch queue stats to libie Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8302be1b-416a-de32-c43b-73bd378f8122@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=drc@linux.vnet.ibm.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=hch@lst.de \
--cc=ilias.apalodimas@linaro.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).