From: Sean Anderson <sean.anderson@linux.dev>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Cc: Willem de Bruijn <willemb@google.com>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: net: csum: Clean up recv_verify_packet_ipv6
Date: Mon, 30 Sep 2024 14:12:37 -0400 [thread overview]
Message-ID: <83297afc-f2fa-4fb6-be0f-f73905f726ef@linux.dev> (raw)
In-Reply-To: <66fadcd4b8f08_18740029417@willemb.c.googlers.com.notmuch>
On 9/30/24 13:16, Willem de Bruijn wrote:
> Sean Anderson wrote:
>> Rename ip_len to payload_len since the length in this case refers only
>> to the payload, and not the entire IP packet like for IPv4. While we're
>> at it, just use the variable directly when calling
>> recv_verify_packet_udp/tcp.
>>
>> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
>
> Not sure such refactoring patches are worth the effort.
Well, FWIW you commented on this in your review, so I figured I'd send it.
https://lore.kernel.org/all/66dbb4fcbf560_2af86229423@willemb.c.googlers.com.notmuch/
--Sean
next prev parent reply other threads:[~2024-09-30 18:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 16:29 [PATCH net-next] selftests: net: csum: Clean up recv_verify_packet_ipv6 Sean Anderson
2024-09-30 17:16 ` Willem de Bruijn
2024-09-30 18:12 ` Sean Anderson [this message]
2024-09-30 18:47 ` Willem de Bruijn
2024-10-04 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83297afc-f2fa-4fb6-be0f-f73905f726ef@linux.dev \
--to=sean.anderson@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).