From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6BA41991B8 for ; Mon, 30 Sep 2024 18:12:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727719967; cv=none; b=RqGlPwMhV7e/T+PF8YZYIa2vGrTB06i4NT/cGnfjPXsH+6SHTozMFGmcXExy00M96D9gwBUqkts+PgI56R7fuxgrnUr3n9liE5iYyZteKTzHLdY5/Cb/GSlfDh+Il4SLx0xCUatWNJ9/iloY2eSKSI0Co07ddIgQMRPNutg+bwg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727719967; c=relaxed/simple; bh=dlu1mH5bGSJsyE1ixR3p8HBxAyolLICTGGEcWVYRtCM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qJfttopbWWhFSVlK8VTrsaDbv0DuJ7YgP6QHKbCssqbvMiaQWfJlEevxZnag6bDTvviMMJaRx72THxFFT+P6pUMTkBEnoBR1p/J/MHV6CUOY1WrAv9XhmSyNeLTlLNfvl/YwbqCCVxX3Ewh8fqeYoWpoiNdIa98rIbCzPuGm8Js= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Of9/INfG; arc=none smtp.client-ip=91.218.175.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Of9/INfG" Message-ID: <83297afc-f2fa-4fb6-be0f-f73905f726ef@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1727719963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aqnjojoj1Y1D57oeAHxWP7P0UrCbjXLwC4A9xtDaDwo=; b=Of9/INfGwyXJypaxCYDs4BIXLb927cUzmwpWOpAWSxcm9QV+BBQI54d5ztfT6PEbme+DI8 fm4x7dNF5yEO0avZdsLuR8pyRURlmz8c/XfKY9A/Ap1b3V8KUCTwyOIN1rxA7r9JHWIBCS WnVDtDMJNo6QIDQKqrzHSZgXslcZo6c= Date: Mon, 30 Sep 2024 14:12:37 -0400 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next] selftests: net: csum: Clean up recv_verify_packet_ipv6 To: Willem de Bruijn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Cc: Willem de Bruijn , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240930162935.980712-1-sean.anderson@linux.dev> <66fadcd4b8f08_18740029417@willemb.c.googlers.com.notmuch> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <66fadcd4b8f08_18740029417@willemb.c.googlers.com.notmuch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 9/30/24 13:16, Willem de Bruijn wrote: > Sean Anderson wrote: >> Rename ip_len to payload_len since the length in this case refers only >> to the payload, and not the entire IP packet like for IPv4. While we're >> at it, just use the variable directly when calling >> recv_verify_packet_udp/tcp. >> >> Signed-off-by: Sean Anderson > > Not sure such refactoring patches are worth the effort. Well, FWIW you commented on this in your review, so I figured I'd send it. https://lore.kernel.org/all/66dbb4fcbf560_2af86229423@willemb.c.googlers.com.notmuch/ --Sean