From: Roger Quadros <rogerq@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>
Cc: Siddharth Vadapalli <s-vadapalli@ti.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
netdev@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH net-next v2 1/4] net: ethernet: ti: am65-cpsw: Convert to platform remove callback returning void
Date: Thu, 30 Nov 2023 11:37:06 +0200 [thread overview]
Message-ID: <83430eb6-256b-4247-9dc8-9e5c68ce76a8@kernel.org> (raw)
In-Reply-To: <20231128173823.867512-2-u.kleine-koenig@pengutronix.de>
On 28/11/2023 19:38, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Replace the error path returning a non-zero value by an error message
> and a comment that there is more to do. With that this patch results in
> no change of behaviour in this driver apart from improving the error
> message.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
next prev parent reply other threads:[~2023-11-30 9:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 17:38 [PATCH net-next v2 0/4] net: ethernet: Convert to platform remove callback returning void Uwe Kleine-König
2023-11-28 17:38 ` [PATCH net-next v2 1/4] net: ethernet: ti: am65-cpsw: " Uwe Kleine-König
2023-11-30 9:37 ` Roger Quadros [this message]
2023-11-28 17:38 ` [PATCH net-next v2 2/4] net: ethernet: ti: cpsw: " Uwe Kleine-König
2023-11-30 9:37 ` Roger Quadros
2023-11-28 17:38 ` [PATCH net-next v2 3/4] net: ethernet: ti: cpsw-new: " Uwe Kleine-König
2023-11-30 9:37 ` Roger Quadros
2023-11-28 17:38 ` [PATCH net-next v2 4/4] net: ethernet: ezchip: " Uwe Kleine-König
2023-11-30 12:10 ` [PATCH net-next v2 0/4] net: ethernet: " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83430eb6-256b-4247-9dc8-9e5c68ce76a8@kernel.org \
--to=rogerq@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s-vadapalli@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).