From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
davem@davemloft.net, "Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Russell King" <linux@armlinux.org.uk>,
thomas.petazzoni@bootlin.com,
"Alexis Lothoré" <alexis.lothore@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH net-next] net: stmmac: Simplify ioctl handling
Date: Tue, 21 Jul 2026 18:56:14 +0200 [thread overview]
Message-ID: <83806c45-ebec-456d-9a48-76bed6bde8eb@bootlin.com> (raw)
In-Reply-To: <20260721094245.1b6aab2d@kernel.org>
Hi Jakub,
On 7/21/26 18:42, Jakub Kicinski wrote:
> On Sat, 18 Jul 2026 16:38:47 +0200 Maxime Chevallier wrote:
>> Now that timestamping is controlled through an NDO, we can simply
>> call phylink_mii_ioctl() to handle ioctls.
>>
>> The only functional difference is that phylink_mii_ioctl() ->
>> phy_mii_ioctl() can handle SIOCSHWTSTAMP, but this no longer happens
>> as this ioctl is not longer dispatched to the ndo_eth_ioctl().
>
> To double check - the discussion is orthogonal and this patch can be
> applied as is?
Indeed yes, the patch itself doesn't introduce any behaviour change.
That's actually when I noticed that it doesn't introduce behaviour changes
(as the SIOCSHWTSTAMP ioctl is masked and doesn't reach the .ndo_ioctl() in
the first place) that I added the small comment that started this discussion :)
Maxime
next prev parent reply other threads:[~2026-07-21 16:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 14:38 [PATCH net-next] net: stmmac: Simplify ioctl handling Maxime Chevallier
2026-07-18 21:19 ` Vadim Fedorenko
2026-07-19 16:13 ` Andrew Lunn
2026-07-20 15:17 ` Vadim Fedorenko
2026-07-20 15:34 ` Maxime Chevallier
2026-07-20 18:12 ` Andrew Lunn
2026-07-20 22:43 ` Vadim Fedorenko
2026-07-21 0:39 ` Andrew Lunn
2026-07-21 16:46 ` Vadim Fedorenko
2026-07-21 16:42 ` Jakub Kicinski
2026-07-21 16:56 ` Maxime Chevallier [this message]
2026-07-21 22:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83806c45-ebec-456d-9a48-76bed6bde8eb@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alexis.lothore@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox