From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73DB7C468A0 for ; Fri, 5 Jul 2019 17:26:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41B0221670 for ; Fri, 5 Jul 2019 17:26:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="PjPImhCJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728088AbfGER0o (ORCPT ); Fri, 5 Jul 2019 13:26:44 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:36872 "EHLO mail-wr1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728047AbfGER0o (ORCPT ); Fri, 5 Jul 2019 13:26:44 -0400 Received: by mail-wr1-f54.google.com with SMTP id n9so1509668wrr.4 for ; Fri, 05 Jul 2019 10:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TeYeBcfv24B0DakZR049hsv/5IqJieRYrN3VQLpo+Yk=; b=PjPImhCJHJQkYzVczllMDRFvOFJM+GIwvPmHN6fb0JypDtWJNPbxPUNfF/GC5yIZLC 59A3I9FmGdvxe0Q9TsG9Ad/qXZfPuc+QaQvzZ+klzPUtN6vwwDAHP7X/LQR2oKArN7DN pe+A2jK+gW1012FvWUnKigUGAETva+Au3iW64EG0olCvJEQh57zOhCKQZQ999a7QU85s Sxdz9drEzCdaWpooOprPh9PKCQzXLB3enTkYp/oA78so/MTL+qi8/7kMM/pCL2XbtnYP f7/kEeVtJFfV79/1JX70kiYe3k2RVnFsFBizfjfxpevZIzvjcmJWAxlZiCAR6T6PQDb0 0mvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=TeYeBcfv24B0DakZR049hsv/5IqJieRYrN3VQLpo+Yk=; b=nHvplSVHVaeLqMs2gfK8nR5fajeF2RhSpgt90bLMUywTgpUD85O7Xz77EQ+G4G6PMN ClMfNlTvA8zMO+7RhOytS/h7tih078T8rI7Em5tCbNCsn/JTPW2P++7Ai8uKlzgO+uAg lTLymwGeqQ8SCft89CN648/kDwIr8pSbqZwMX36H0EA6wtkdePE/6DTg6Aj11iu0ak4f js8WYWggub4LC7fxNa8YlihNzTcKF7AzPtysh8cPQOkKSF4o1lOl74ICD+SPKQfCmgWE o9WANIPiJWJ8SQcUk73cig2pyI0bV2fH4/F2kpTwfGGaGek4YFUYpS4ci5x9CyjeZeEM MasQ== X-Gm-Message-State: APjAAAXmWGQ265iNr/KCk/ai9JwwPrnoMK5R5w4BfzTXToxTVOIFRmSe N6tWNPXBtBNvTAzMnOTBjuLxKQ== X-Google-Smtp-Source: APXvYqyBZC38NsIrIMPcdT3/9zOoKV0bdg4yIdb9lij6Wlnwz3qcl/M0UPy6xsXNpbIhqjXucchKYA== X-Received: by 2002:a5d:4d10:: with SMTP id z16mr4895854wrt.112.1562347601895; Fri, 05 Jul 2019 10:26:41 -0700 (PDT) Received: from [172.20.1.254] ([217.38.71.146]) by smtp.gmail.com with ESMTPSA id x11sm7631232wmi.26.2019.07.05.10.26.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jul 2019 10:26:41 -0700 (PDT) Subject: Re: [PATCHv2] tools bpftool: Fix json dump crash on powerpc To: Jakub Kicinski , Jiri Olsa Cc: Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , Michael Petlan , netdev@vger.kernel.org, bpf@vger.kernel.org, Martin KaFai Lau References: <20190704085856.17502-1-jolsa@kernel.org> <20190704134210.17b8407c@cakuba.netronome.com> <20190705121031.GA10777@krava> <20190705102452.0831942a@cakuba.netronome.com> From: Quentin Monnet Openpgp: preference=signencrypt Autocrypt: addr=quentin.monnet@netronome.com; prefer-encrypt=mutual; keydata= mQINBFnqRlsBEADfkCdH/bkkfjbglpUeGssNbYr/TD4aopXiDZ0dL2EwafFImsGOWmCIIva2 MofTQHQ0tFbwY3Ir74exzU9X0aUqrtHirQHLkKeMwExgDxJYysYsZGfM5WfW7j8X4aVwYtfs AVRXxAOy6/bw1Mccq8ZMTYKhdCgS3BfC7qK+VYC4bhM2AOWxSQWlH5WKQaRbqGOVLyq8Jlxk 2FGLThUsPRlXKz4nl+GabKCX6x3rioSuNoHoWdoPDKsRgYGbP9LKRRQy3ZeJha4x+apy8rAM jcGHppIrciyfH38+LdV1FVi6sCx8sRKX++ypQc3fa6O7d7mKLr6uy16xS9U7zauLu1FYLy2U N/F1c4F+bOlPMndxEzNc/XqMOM9JZu1XLluqbi2C6JWGy0IYfoyirddKpwzEtKIwiDBI08JJ Cv4jtTWKeX8pjTmstay0yWbe0sTINPh+iDw+ybMwgXhr4A/jZ1wcKmPCFOpb7U3JYC+ysD6m 6+O/eOs21wVag/LnnMuOKHZa2oNsi6Zl0Cs6C7Vve87jtj+3xgeZ8NLvYyWrQhIHRu1tUeuf T8qdexDphTguMGJbA8iOrncHXjpxWhMWykIyN4TYrNwnyhqP9UgqRPLwJt5qB1FVfjfAlaPV sfsxuOEwvuIt19B/3pAP0nbevNymR3QpMPRl4m3zXCy+KPaSSQARAQABtC1RdWVudGluIE1v bm5ldCA8cXVlbnRpbi5tb25uZXRAbmV0cm9ub21lLmNvbT6JAj0EEwEIACcFAlnqRlsCGyMF CQlmAYAFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQNvcEyYwwfB7tChAAqFWG30+DG3Sx B7lfPaqs47oW98s5tTMprA+0QMqUX2lzHX7xWb5v8qCpuujdiII6RU0ZhwNKh/SMJ7rbYlxK qCOw54kMI+IU7UtWCej+Ps3LKyG54L5HkBpbdM8BLJJXZvnMqfNWx9tMISHkd/LwogvCMZrP TAFkPf286tZCIz0EtGY/v6YANpEXXrCzboWEiIccXRmbgBF4VK/frSveuS7OHKCu66VVbK7h kyTgBsbfyQi7R0Z6w6sgy+boe7E71DmCnBn57py5OocViHEXRgO/SR7uUK3lZZ5zy3+rWpX5 nCCo0C1qZFxp65TWU6s8Xt0Jq+Fs7Kg/drI7b5/Z+TqJiZVrTfwTflqPRmiuJ8lPd+dvuflY JH0ftAWmN3sT7cTYH54+HBIo1vm5UDvKWatTNBmkwPh6d3cZGALZvwL6lo0KQHXZhCVdljdQ rwWdE25aCQkhKyaCFFuxr3moFR0KKLQxNykrVTJIRuBS8sCyxvWcZYB8tA5gQ/DqNKBdDrT8 F9z2QvNE5LGhWDGddEU4nynm2bZXHYVs2uZfbdZpSY31cwVS/Arz13Dq+McMdeqC9J2wVcyL DJPLwAg18Dr5bwA8SXgILp0QcYWtdTVPl+0s82h+ckfYPOmkOLMgRmkbtqPhAD95vRD7wMnm ilTVmCi6+ND98YblbzL64YG5Ag0EWepGWwEQAM45/7CeXSDAnk5UMXPVqIxF8yCRzVe+UE0R QQsdNwBIVdpXvLxkVwmeu1I4aVvNt3Hp2eiZJjVndIzKtVEoyi5nMvgwMVs8ZKCgWuwYwBzU Vs9eKABnT0WilzH3gA5t9LuumekaZS7z8IfeBlZkGXEiaugnSAESkytBvHRRlQ8b1qnXha3g XtxyEqobKO2+dI0hq0CyUnGXT40Pe2woVPm50qD4HYZKzF5ltkl/PgRNHo4gfGq9D7dW2OlL 5I9qp+zNYj1G1e/ytPWuFzYJVT30MvaKwaNdurBiLc9VlWXbp53R95elThbrhEfUqWbAZH7b ALWfAotD07AN1msGFCES7Zes2AfAHESI8UhVPfJcwLPlz/Rz7/K6zj5U6WvH6aj4OddQFvN/ icvzlXna5HljDZ+kRkVtn+9zrTMEmgay8SDtWliyR8i7fvnHTLny5tRnE5lMNPRxO7wBwIWX TVCoBnnI62tnFdTDnZ6C3rOxVF6FxUJUAcn+cImb7Vs7M5uv8GufnXNUlsvsNS6kFTO8eOjh 4fe5IYLzvX9uHeYkkjCNVeUH5NUsk4NGOhAeCS6gkLRA/3u507UqCPFvVXJYLSjifnr92irt 0hXm89Ms5fyYeXppnO3l+UMKLkFUTu6T1BrDbZSiHXQoqrvU9b1mWF0CBM6aAYFGeDdIVe4x ABEBAAGJAiUEGAEIAA8FAlnqRlsCGwwFCQlmAYAACgkQNvcEyYwwfB4QwhAAqBTOgI9k8MoM gVA9SZj92vYet9gWOVa2Inj/HEjz37tztnywYVKRCRfCTG5VNRv1LOiCP1kIl/+crVHm8g78 iYc5GgBKj9O9RvDm43NTDrH2uzz3n66SRJhXOHgcvaNE5ViOMABU+/pzlg34L/m4LA8SfwUG ducP39DPbF4J0OqpDmmAWNYyHh/aWf/hRBFkyM2VuizN9cOS641jrhTO/HlfTlYjIb4Ccu9Y S24xLj3kkhbFVnOUZh8celJ31T9GwCK69DXNwlDZdri4Bh0N8DtRfrhkHj9JRBAun5mdwF4m yLTMSs4Jwa7MaIwwb1h3d75Ws7oAmv7y0+RgZXbAk2XN32VM7emkKoPgOx6Q5o8giPRX8mpc PiYojrO4B4vaeKAmsmVer/Sb5y9EoD7+D7WygJu2bDrqOm7U7vOQybzZPBLqXYxl/F5vOobC 5rQZgudR5bI8uQM0DpYb+Pwk3bMEUZQ4t497aq2vyMLRi483eqT0eG1QBE4O8dFNYdK5XUIz oHhplrRgXwPBSOkMMlLKu+FJsmYVFeLAJ81sfmFuTTliRb3Fl2Q27cEr7kNKlsz/t6vLSEN2 j8x+tWD8x53SEOSn94g2AyJA9Txh2xBhWGuZ9CpBuXjtPrnRSd8xdrw36AL53goTt/NiLHUd RHhSHGnKaQ6MfrTge5Q0h5A= Message-ID: <83d18af0-8efa-c8d5-3d99-01aed29915df@netronome.com> Date: Fri, 5 Jul 2019 18:26:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190705102452.0831942a@cakuba.netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2019-07-05 10:24 UTC-0700 ~ Jakub Kicinski > On Fri, 5 Jul 2019 14:10:31 +0200, Jiri Olsa wrote: >> Michael reported crash with by bpf program in json mode on powerpc: >> >> # bpftool prog -p dump jited id 14 >> [{ >> "name": "0xd00000000a9aa760", >> "insns": [{ >> "pc": "0x0", >> "operation": "nop", >> "operands": [null >> ] >> },{ >> "pc": "0x4", >> "operation": "nop", >> "operands": [null >> ] >> },{ >> "pc": "0x8", >> "operation": "mflr", >> Segmentation fault (core dumped) >> >> The code is assuming char pointers in format, which is not always >> true at least for powerpc. Fixing this by dumping the whole string >> into buffer based on its format. >> >> Please note that libopcodes code does not check return values from >> fprintf callback, but as per Jakub suggestion returning -1 on allocation >> failure so we do the best effort to propagate the error. >> >> Reported-by: Michael Petlan >> Signed-off-by: Jiri Olsa > > Thanks, let me repost all the tags (Quentin, please shout if you're > not ok with this :)): I confirm it's all good for me, thanks :) > > Fixes: 107f041212c1 ("tools: bpftool: add JSON output for `bpftool prog dump jited *` command") > Reviewed-by: Quentin Monnet > Reviewed-by: Jakub Kicinski >