netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Florian Westphal <fw@strlen.de>, NeilBrown <neilb@suse.com>
Subject: Re: [RFC PATCH] ip: re-introduce fragments cache worker
Date: Mon, 09 Jul 2018 11:43:37 +0200	[thread overview]
Message-ID: <83d36724c67d89f3cecec70f45179160653a2c01.camel@redhat.com> (raw)
In-Reply-To: <8480556a-b0a3-5e1a-d1b7-726c52b52046@gmail.com>

On Fri, 2018-07-06 at 07:20 -0700, Eric Dumazet wrote:
> I will test/polish it later, I am coming back from vacations and have a backlog.
> 
> Here are my results : (Note that I have _not_ changed /proc/sys/net/ipv4/ipfrag_time )
> 
> lpaa6:~# grep . /proc/sys/net/ipv4/ipfrag_* ; grep FRAG /proc/net/sockstat
> /proc/sys/net/ipv4/ipfrag_high_thresh:104857600
> /proc/sys/net/ipv4/ipfrag_low_thresh:78643200
> /proc/sys/net/ipv4/ipfrag_max_dist:0
> /proc/sys/net/ipv4/ipfrag_secret_interval:0
> /proc/sys/net/ipv4/ipfrag_time:30
> FRAG: inuse 1379 memory 105006776
> 
> lpaa5:/export/hda3/google/edumazet# ./super_netperf 400 -H 10.246.7.134 -t UDP_STREAM -l 60
> netperf: send_omni: send_data failed: No route to host
> netperf: send_omni: send_data failed: No route to host
>    9063
> 
> 
> I would say that it looks pretty good to me.

Is that with an unmodifed kernel?

I would be happy if I could replicate such results. With the same
configuration I see:

[netdev9 ~]# grep . /proc/sys/net/ipv4/ipfrag_*; nstat>/dev/null; sleep 1; nstat|grep IpR; grep FRAG /proc/net/sockstat
/proc/sys/net/ipv4/ipfrag_high_thresh:104857600
/proc/sys/net/ipv4/ipfrag_low_thresh:3145728
/proc/sys/net/ipv4/ipfrag_max_dist:64
/proc/sys/net/ipv4/ipfrag_secret_interval:0
/proc/sys/net/ipv4/ipfrag_time:30
IpReasmReqds                    827385             0.0
IpReasmFails                    827385             0.0
FRAG: inuse 1038 memory 105326208

[netdev8 ~]# ./super_netperf.sh 400 -H 192.168.101.2 -t UDP_STREAM -l 60 
213.6

Note: this setup is intentionally lossy (on the sender side), to stress
the frag cache:

[netdev8 ~]#  tc -s qdisc show dev em1
qdisc mq 8001: root 
 Sent 73950097203 bytes 49639120 pkt (dropped 2052241, overlimits 0 requeues 41) 
 backlog 0b 0p requeues 41 
# ...

drops here are due to ldelay being higher than fq_codel's target (I use
fq_codel default values). Can you please share your sender's TC conf
and number of tx queues? 

Thanks,

Paolo

  reply	other threads:[~2018-07-09  9:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 10:10 [RFC PATCH] ip: re-introduce fragments cache worker Paolo Abeni
2018-07-06 11:23 ` Eric Dumazet
2018-07-06 11:56   ` Paolo Abeni
2018-07-06 12:09     ` Eric Dumazet
2018-07-06 13:56       ` Paolo Abeni
2018-07-06 14:20         ` Eric Dumazet
2018-07-09  9:43           ` Paolo Abeni [this message]
2018-07-09 11:34             ` Eric Dumazet
2018-07-09 11:39               ` Eric Dumazet
2018-07-09 12:50                 ` Eric Dumazet
2018-07-20 14:48                   ` Paolo Abeni
2018-07-20 15:58                     ` Eric Dumazet
2018-07-20 17:31                       ` Paolo Abeni
2018-07-20 17:37                         ` Eric Dumazet
2018-07-06 14:37         ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83d36724c67d89f3cecec70f45179160653a2c01.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=fw@strlen.de \
    --cc=neilb@suse.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).