From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pekka Enberg Subject: Re: [PATCH] slub: fix slab_pad_check() and SLAB_DESTROY_BY_RCU Date: Thu, 3 Sep 2009 17:05:30 +0300 Message-ID: <84144f020909030705x7909cf07w7ea0d3662a66c5cc@mail.gmail.com> References: <4A896324.3040104@trash.net> <4A9EEF07.5070800@gmail.com> <4A9F1620.2080105@gmail.com> <84144f020909022331x2b275aa5n428f88670e0ae8bc@mail.gmail.com> <4A9F7283.1090306@gmail.com> <84144f020909030051u6cf6ae01he25c268f718ff3af@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Eric Dumazet , Zdenek Kabelac , Patrick McHardy , Robin Holt , Linux Kernel Mailing List , Jesper Dangaard Brouer , Linux Netdev List , Netfilter Developers , paulmck@linux.vnet.ibm.com To: Christoph Lameter Return-path: In-Reply-To: Sender: netfilter-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Christoph, On Thu, 3 Sep 2009, Pekka Enberg wrote: >> Oh, sure, the fix looks sane to me. It's just that I am a complete >> coward when it comes to merging RCU related patches so I always try to >> fish an Acked-by from Paul or Christoph ;). On Thu, Sep 3, 2009 at 8:50 PM, Christoph Lameter wrote: > I am fine with acking the poison piece. Ok. On Thu, Sep 3, 2009 at 8:50 PM, Christoph Lameter wrote: > I did not ack the patch that added rcu to kmem_cache_destroy() and I > likely wont ack that piece either. Right. I didn't remember that I merged that over your NAK but I don't share your view that kmem_cache_destroy() callers should do rcu_barrier() or whatever is necessary if we can do it from kmem_cache_destroy(). So I am happy to take both changes but I would appreciate them being split into two separate patches. Pekka