Netdev List
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>, lucien.xin@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6: fix a dst leak when removing its exception
Date: Mon, 19 Nov 2018 19:19:54 -0700	[thread overview]
Message-ID: <846bd1a6-c11a-7e87-d386-ad5d91595435@cumulusnetworks.com> (raw)
In-Reply-To: <20181119.181617.1403625899925070224.davem@davemloft.net>

On 11/19/18 7:16 PM, David Miller wrote:
> From: Xin Long <lucien.xin@gmail.com>
> Date: Thu, 15 Nov 2018 16:23:38 +0900
> 
>> The attachment is the ip6_dst.sh with IPVS.
>>
>> # sh ip6_dst.sh
> 
> Maybe a selftests candidate?
> 

That script was not a reliable reproducer for me.

I created a much simpler one that shows the problem every time - and
proves the change. It needs some adjustments to work as a selftest.
Specifically, it needs to check dmesg for net_device reference counts
after the rcu delay. I'll add to the to-do list.

  reply	other threads:[~2018-11-20 12:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 16:48 [PATCH net] ipv6: fix a dst leak when removing its exception Xin Long
2018-11-14 19:03 ` David Ahern
2018-11-15  6:33   ` David Ahern
2018-11-15  7:23     ` Xin Long
2018-11-15 18:17       ` David Ahern
2018-11-15 19:13         ` Mika Penttilä
2018-11-20  2:16       ` David Miller
2018-11-20  2:19         ` David Ahern [this message]
2018-11-15 19:49 ` David Ahern
2018-11-17  3:45 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=846bd1a6-c11a-7e87-d386-ad5d91595435@cumulusnetworks.com \
    --to=dsa@cumulusnetworks.com \
    --cc=davem@davemloft.net \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox