netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Changwoo Min <changwoo@igalia.com>
Cc: kernel-dev@igalia.com, linux-pm@vger.kernel.org,
	horms@kernel.org, pabeni@redhat.com, rafael@kernel.org,
	netdev@vger.kernel.org, edumazet@google.com, davem@davemloft.net,
	sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org,
	lenb@kernel.org, pavel@kernel.org, donald.hunter@gmail.com,
	kuba@kernel.org
Subject: Re: [PATCH for 6.19 0/4] Revise the EM YNL spec to be clearer
Date: Tue, 30 Dec 2025 09:44:21 +0000	[thread overview]
Message-ID: <849b576e-9563-42ae-bd5c-756fb6dfd8de@arm.com> (raw)
In-Reply-To: <20251225040104.982704-1-changwoo@igalia.com>

Hi Changwoo,

On 12/25/25 04:01, Changwoo Min wrote:
> This patch set addresses all the concerns raised at [1] to make the EM YNL spec
> clearer. It includes the following changes:
> 
> - Fix the lint errors (1/4).
> - Rename em.yaml to dev-energymodel.yaml (2/4).  “dev-energymodel” was used
>    instead of “device-energy-model”, which was originally proposed [2], because
>    the netlink protocol name cannot exceed GENL_NAMSIZ(16). In addition, docs
>    strings and flags attributes were added.
> - Change cpus' type from string to u64 array of CPU ids (3/4).
> - Add dump to get-perf-domains in the EM YNL spec (4/4). A user can fetch
>    either information about a specific performance domain with do or information
>    about all performance domains with dump.
> 
> This can be tested using the tool, tools/net/ynl/pyynl/cli.py, for example,
> with the following commands:
> 
>    $> tools/net/ynl/pyynl/cli.py \
>       --spec Documentation/netlink/specs/dev-energymodel.yaml \
>       --dump get-perf-domains
>    $> tools/net/ynl/pyynl/cli.py \
>       --spec Documentation/netlink/specs/dev-energymodel.yaml \
>       --do get-perf-domains --json '{"perf-domain-id": 0}'
>    $> tools/net/ynl/pyynl/cli.py \
>       --spec Documentation/netlink/specs/dev-energymodel.yaml \
>       --do get-perf-table --json '{"perf-domain-id": 0}'
>    $> tools/net/ynl/pyynl/cli.py \
>       --spec Documentation/netlink/specs/dev-energymodel.yaml \
>       --subscribe event  --sleep 10
> 
> [1] https://lore.kernel.org/lkml/CAD4GDZy-aeWsiY=-ATr+Y4PzhMX71DFd_mmdMk4rxn3YG8U5GA@mail.gmail.com/
> [2] https://lore.kernel.org/lkml/CAJZ5v0gpYQwC=1piaX-PNoyeoYJ7uw=DtAGdTVEXAsi4bnSdbA@mail.gmail.com/

My apologies, I've missed those conversations (not the best season).

So what would be the procedure here for the review?
Could Folks from netlink help here?

I will do my bit for the EM related stuff (to double-check them).

Regards,
Lukasz

  parent reply	other threads:[~2025-12-30  9:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-25  4:01 [PATCH for 6.19 0/4] Revise the EM YNL spec to be clearer Changwoo Min
2025-12-25  4:01 ` [PATCH for 6.19 1/4] PM: EM: Fix yamllint warnings in the EM YNL spec Changwoo Min
2025-12-31 17:20   ` Donald Hunter
2025-12-25  4:01 ` [PATCH for 6.19 2/4] PM: EM: Rename em.yaml to dev-energymodel.yaml Changwoo Min
2025-12-25  4:01 ` [PATCH for 6.19 3/4] PM: EM: Change cpus' type from string to u64 array in the EM YNL spec Changwoo Min
2025-12-25  4:01 ` [PATCH for 6.19 4/4] PM: EM: Add dump to get-perf-domains " Changwoo Min
2025-12-30  9:44 ` Lukasz Luba [this message]
2025-12-30 12:56   ` [PATCH for 6.19 0/4] Revise the EM YNL spec to be clearer Donald Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=849b576e-9563-42ae-bd5c-756fb6dfd8de@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=changwoo@igalia.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kernel-dev@igalia.com \
    --cc=kuba@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavel@kernel.org \
    --cc=rafael@kernel.org \
    --cc=sched-ext@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).