From: Luciano Coelho <luciano.coelho@intel.com>
To: YueHaibing <yuehaibing@huawei.com>,
johannes.berg@intel.com, emmanuel.grumbach@intel.com,
linuxwifi@intel.com, kvalo@codeaurora.org, sara.sharon@intel.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: mvm: fix old-style declaration
Date: Fri, 23 Aug 2019 08:17:39 +0300 [thread overview]
Message-ID: <84a882c0bd2954c21735005534abb5568b2fc806.camel@intel.com> (raw)
In-Reply-To: <20190726141838.19424-1-yuehaibing@huawei.com>
On Fri, 2019-07-26 at 22:18 +0800, YueHaibing wrote:
> There expect the 'static' keyword to come first in a
> declaration, and we get a warning for this with "make W=1":
>
> drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:427:1: warning:
> 'static' is not at beginning of declaration [-Wold-style-declaration]
> drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:434:1: warning:
> 'static' is not at beginning of declaration [-Wold-style-declaration]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
Thanks! Johannes applied this in our internal tree a few weeks ago and
it will reach the mainline following our usual upstreaming process.
--
Cheers,
Luca.
prev parent reply other threads:[~2019-08-23 5:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 14:18 [PATCH] iwlwifi: mvm: fix old-style declaration YueHaibing
2019-08-23 5:17 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84a882c0bd2954c21735005534abb5568b2fc806.camel@intel.com \
--to=luciano.coelho@intel.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sara.sharon@intel.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox