From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE9CFC433F5 for ; Tue, 4 Oct 2022 11:18:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229496AbiJDLSf (ORCPT ); Tue, 4 Oct 2022 07:18:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229588AbiJDLSe (ORCPT ); Tue, 4 Oct 2022 07:18:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 365861F2D1 for ; Tue, 4 Oct 2022 04:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664882312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gnepkY0TgZKqop1C+S4YBSp9YXD3uP2dxXvg2KODGSM=; b=Kby47hge2xVcI2R4Tu1IFrucrViIoLIzdKoB7FukcmKtMJ6s7xHgorElwJLaWrUZvnmgrv lyVds3LFudCXs7IfVZfuftFybiWpdw7rsCMJPsHEkXNMP/rIcFgx5cRnV1xXmHer1cMH+U eQ99Uxv0CUJQQlncIxvFWp0uzBgHo+I= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-651-CUBFjQMFMFe_lZe5lpRZ_w-1; Tue, 04 Oct 2022 07:18:31 -0400 X-MC-Unique: CUBFjQMFMFe_lZe5lpRZ_w-1 Received: by mail-ed1-f72.google.com with SMTP id t19-20020a056402525300b00459546fd250so1309581edd.23 for ; Tue, 04 Oct 2022 04:18:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date; bh=gnepkY0TgZKqop1C+S4YBSp9YXD3uP2dxXvg2KODGSM=; b=62MA0RdBZ23sWUbB6xhmMRgJIj2fd+hvZQ6hpAmmGO0MIBjOvwm6uBzL9TvKDXlMZK VAXz1xMnsANIEAYoPRymt5vghIGhb+bwch9+/QAEWt2VQ3U7Y6kFkb7373ZIFuhqnZC+ /OFBgOu/ivyYhDqDJhl0uo1NzV9Xw4ovS3ACibYLOI+x/ZSOtwroI42JkJFr2nDsAm7q BmIVT8/R8t37m1Fk/VEnahntbHH9V8X/QeEz53YdOE5RQ8CVvpsAfcz3GLuaFmUF0Hwu VCYmR3HdzAQkDgyyjahJHeJQpqafMzk/WSGEgoNJxdiWvLzLq6wQ4Rfltk1HKEn7aZQk 1BUA== X-Gm-Message-State: ACrzQf0nZ19Vpj3SbEhw2I3mFiEDoxn5o8XXtBzQsq5wwMgP7asrYFBd oFimbtsUzvC3MPz26miivtyxwFcC8LXUDCMbQLl0EZZyTMXA4Xw5ZL0J+ikX+hFCpbfAd+nQqzb aaRpzYlSfNtlvmfGU X-Received: by 2002:a05:6402:90a:b0:458:ca4d:a2f8 with SMTP id g10-20020a056402090a00b00458ca4da2f8mr12409288edz.230.1664882309710; Tue, 04 Oct 2022 04:18:29 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5wxjDzIjFVczqqYoXyO3JSiwl1e1NNSpIMVWjPSFP032LsEqgpeVHfPd879v/3Em5EYMMGTQ== X-Received: by 2002:a05:6402:90a:b0:458:ca4d:a2f8 with SMTP id g10-20020a056402090a00b00458ca4da2f8mr12409263edz.230.1664882309499; Tue, 04 Oct 2022 04:18:29 -0700 (PDT) Received: from [192.168.41.81] (83-90-141-187-cable.dk.customer.tdc.net. [83.90.141.187]) by smtp.gmail.com with ESMTPSA id g2-20020a17090604c200b0073d7bef38e3sm6839369eja.45.2022.10.04.04.18.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 04:18:28 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: <850048b2-ec8b-26db-6ea7-92ed30aab207@redhat.com> Date: Tue, 4 Oct 2022 13:18:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Cc: brouer@redhat.com, "David S . Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Wei Fang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Ilias Apalodimas Subject: Re: [PATCH v2 1/1] net: fec: using page pool to manage RX buffers Content-Language: en-US To: Jakub Kicinski , Shenwei Wang References: <20220930204427.1299077-1-shenwei.wang@nxp.com> <20221003165157.2bbdae26@kernel.org> In-Reply-To: <20221003165157.2bbdae26@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 04/10/2022 01.51, Jakub Kicinski wrote: > On Fri, 30 Sep 2022 15:44:27 -0500 Shenwei Wang wrote: >> This patch optimizes the RX buffer management by using the page >> pool. The purpose for this change is to prepare for the following >> XDP support. The current driver uses one frame per page for easy >> management. > > I believe this has been applied as: > > commit 95698ff6177b ("net: fec: using page pool to manage RX buffers") > > to net-next. Thanks! > Sorry, that I was not quick enough to review and ACK this patch. I just went over it quickly and the page_pool adding LGTM, so: Acked-by: Jesper Dangaard Brouer