From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24C6CC43381 for ; Sun, 24 Mar 2019 06:03:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC7632148D for ; Sun, 24 Mar 2019 06:03:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P4olk64i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727252AbfCXF6U (ORCPT ); Sun, 24 Mar 2019 01:58:20 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:53454 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726173AbfCXF6U (ORCPT ); Sun, 24 Mar 2019 01:58:20 -0400 Received: by mail-wm1-f66.google.com with SMTP id q16so5735618wmj.3 for ; Sat, 23 Mar 2019 22:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fMtbjFnDbzlxrtdEQpVh+D/Q65EvbKLZNe0Z9T9D/Og=; b=P4olk64i+YUsOesVW5LhOq6LeerjoWgqk4jd4vRBkCQeDkU5EVvs1Y+JxiNMd6a9Wk Gd45aORrOr2Qcthzw/lXmAtmxJWRy9MdQ3AUUFf7aC9W8o5KBpSwFD6AiYK1WpqirOXM 482g3djppTs094PKLygqJ0MJmsZ2gy6MYeoDFEl0AmxWk5unvMxmhBLzQ+QYjTmbH048 jv52SvnlSDo+ZOEeg/P8zkhurEsnWIV4tJIWroH2asnqKFGmNi3pyVFtZquNIoiBrryD toyLM0yg+mjMA1UyhgyvAmBGXdi8s3ReLuLUTOWl1DzHCl+bg7TElMIaexH7eOpIKpm1 lRkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fMtbjFnDbzlxrtdEQpVh+D/Q65EvbKLZNe0Z9T9D/Og=; b=tDZ3+iJLYHTaPQOqErG2kY/9VCBT0bESHhfGj6lf+s8bjCqnKk4O9v5PFTZ2QhwHfd 7wykdn+VV5NsfWTamYQyjFEKbobOMmp+Ef35PHM5wOKHh2owGxvlUpfvgcO0U5zaZYRm tIoHTsmTouetWd5KKJikF9IIC1wcSvZHH8fMr8Z9SL3j3wZsLOphjhe/f+c/FjOmkf2l ZAsj2qMIlkAWU8akcyGL/Nz0xi6N2TWPdruKXLHHiG+m0jPdjGACwrHCFkNDBdWEJECK qPFxjR0/mR0i4nTpNdKI1NbBvDh1HTvFdcN++UCIEbPf8Fhmk0PyhOZn2zMp752ipCTl lhmQ== X-Gm-Message-State: APjAAAVPieeiODvdDPW5F6airrVY2CIoRJD33cnY4A2dOdjB/uI0lj89 3pJejFzFWVhPM5GvVYunbzc= X-Google-Smtp-Source: APXvYqzr+7kZ8cvz28NZFrqLtdmcFEPhWy8EGGFYEz4bG5StTaD5QiV++gyaAPw7EluPEDNamOYITA== X-Received: by 2002:a1c:a749:: with SMTP id q70mr1520910wme.151.1553407099030; Sat, 23 Mar 2019 22:58:19 -0700 (PDT) Received: from [192.168.8.147] (186.198.23.93.rev.sfr.net. [93.23.198.186]) by smtp.gmail.com with ESMTPSA id a17sm18086154wmg.40.2019.03.23.22.58.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Mar 2019 22:58:18 -0700 (PDT) Subject: Re: [PATCH bpf-next 0/7] bpf: Propagate cn to TCP To: Lawrence Brakmo , Eric Dumazet , netdev Cc: Martin Lau , Alexei Starovoitov , Daniel Borkmann , Kernel Team References: <20190323080542.173569-1-brakmo@fb.com> <704cb63c-13cd-f0ed-d546-18e3596bb63d@gmail.com> <148E4177-8064-4824-898A-997C145E19B6@fb.com> From: Eric Dumazet Message-ID: <85255236-51ef-bcfc-9270-99b503047497@gmail.com> Date: Sat, 23 Mar 2019 22:58:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <148E4177-8064-4824-898A-997C145E19B6@fb.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/23/2019 06:14 PM, Lawrence Brakmo wrote: > There was no eBPF at that time. We like the flexibility we get by programing > the algorithms in eBPF. eBPF being there does not mean we can adopt whatever research work, we want evaluations of the costs and benefits. > > These are not intrusive changes, they simply extend the current limited return > values form cgroup skb egress BPF programs to be more in line with qdiscs. They are quite intrusive changes to IP layer, we can not deny this.