From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Mashak Subject: Re: [PATCH v2 iproute2 net-next] erspan: add erspan version II support Date: Fri, 15 Dec 2017 18:58:03 -0500 Message-ID: <854lorfss4.fsf@mojatatu.com> References: <1513374172-5875-1-git-send-email-u9012063@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Cc: netdev@vger.kernel.org To: William Tu Return-path: Received: from mail-io0-f196.google.com ([209.85.223.196]:36108 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755795AbdLOX6G (ORCPT ); Fri, 15 Dec 2017 18:58:06 -0500 Received: by mail-io0-f196.google.com with SMTP id l10so4334666ioc.3 for ; Fri, 15 Dec 2017 15:58:06 -0800 (PST) In-Reply-To: <1513374172-5875-1-git-send-email-u9012063@gmail.com> (William Tu's message of "Fri, 15 Dec 2017 13:42:52 -0800") Sender: netdev-owner@vger.kernel.org List-ID: William Tu writes: > The patch adds support for configuring the erspan v2, for both > ipv4 and ipv6 erspan implementation. Three additional fields > are added: 'erspan_ver' for distinguishing v1 or v2, 'erspan_dir' > for specifying direction of the mirrored traffic, and 'erspan_hwid' > for users to set ERSPAN engine ID within a system. > > As for manpage, the ERSPAN descriptions used to be under GRE, IPIP, > SIT Type paragraph. Since IP6GRE/IP6GRETAP also supports ERSPAN, > the patch removes the old one, creates a separate ERSPAN paragrah, > and adds an example. > > Signed-off-by: William Tu > --- > change in v2: > - clean up and update manpage. > --- > include/uapi/linux/if_ether.h | 1 + > include/uapi/linux/if_tunnel.h | 3 ++ > ip/link_gre.c | 59 ++++++++++++++++++++++++-- > ip/link_gre6.c | 61 +++++++++++++++++++++++++-- > man/man8/ip-link.8.in | 94 ++++++++++++++++++++++++++++++++++++------ > 5 files changed, 199 insertions(+), 19 deletions(-) > > diff --git a/include/uapi/linux/if_ether.h b/include/uapi/linux/if_ether.h > index 2eb529a90250..5fd5c12ef8e9 100644 > --- a/include/uapi/linux/if_ether.h > +++ b/include/uapi/linux/if_ether.h > @@ -47,6 +47,7 @@ > #define ETH_P_PUP 0x0200 /* Xerox PUP packet */ > #define ETH_P_PUPAT 0x0201 /* Xerox PUP Addr Trans packet */ > #define ETH_P_TSN 0x22F0 /* TSN (IEEE 1722) packet */ > +#define ETH_P_ERsPAN2 0x22EB /* ERSPAN version 2 (type III) */ ^ Is it intention to have a lower case 's' in macro name or typo? [...]