From: Roman Mashak <mrv@mojatatu.com>
To: Petr Machata <petrm@mellanox.com>
Cc: Ido Schimmel <idosch@idosch.org>,
netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, kuba@kernel.org,
mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next 1/6] selftests: qdiscs: Add TDC test for RED
Date: Tue, 10 Mar 2020 13:28:22 -0400 [thread overview]
Message-ID: <855zfc5dc9.fsf@mojatatu.com> (raw)
In-Reply-To: <87pndkxi64.fsf@mellanox.com> (Petr Machata's message of "Tue, 10 Mar 2020 17:56:35 +0100")
Petr Machata <petrm@mellanox.com> writes:
> Roman Mashak <mrv@mojatatu.com> writes:
>
>> Ido Schimmel <idosch@idosch.org> writes:
>>
>>> From: Petr Machata <petrm@mellanox.com>
>>>
>>> Add a handful of tests for creating RED with different flags.
>>>
>>
>> Thanks for adding new tests in TDC.
>>
>> Could you give more descriptive names for tests? (Look at
>> tc-tests/qdiscs/fifo.json or tc-tests/qdiscs/ets.json as examples)
>
> Yep.
>
>> Did you try running this with nsPlugin enabled? I think you would need
>> to add the following for every test:
>
> Is there a flag that I need to use to enable nsPlugin? I put in the the
> "plugins" stanza that you cite below and didn't observe any changes.
> That either means that it works or that it has no effect :)
Look at plugin-lib/README-PLUGINS how to enable the plugin.
next prev parent reply other threads:[~2020-03-10 17:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 18:34 [PATCH net-next 0/6] RED: Introduce an ECN tail-dropping mode Ido Schimmel
2020-03-09 18:34 ` [PATCH net-next 1/6] selftests: qdiscs: Add TDC test for RED Ido Schimmel
2020-03-10 15:40 ` Roman Mashak
2020-03-10 16:56 ` Petr Machata
2020-03-10 17:28 ` Roman Mashak [this message]
2020-03-09 18:34 ` [PATCH net-next 2/6] net: sched: Add centralized RED flag checking Ido Schimmel
2020-03-09 22:18 ` Jakub Kicinski
2020-03-10 9:48 ` Petr Machata
2020-03-10 19:53 ` Jakub Kicinski
2020-03-10 22:23 ` Petr Machata
2020-03-10 23:00 ` Jakub Kicinski
2020-03-10 23:53 ` Petr Machata
2020-03-09 18:35 ` [PATCH net-next 3/6] net: sched: RED: Introduce an ECN tail-dropping mode Ido Schimmel
2020-03-09 22:12 ` Jakub Kicinski
2020-03-10 9:48 ` Petr Machata
2020-03-09 18:35 ` [PATCH net-next 4/6] mlxsw: spectrum_qdisc: Offload RED " Ido Schimmel
2020-03-09 18:35 ` [PATCH net-next 5/6] selftests: qdiscs: RED: Add taildrop tests Ido Schimmel
2020-03-09 18:35 ` [PATCH net-next 6/6] selftests: mlxsw: RED: Test RED ECN taildrop offload Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=855zfc5dc9.fsf@mojatatu.com \
--to=mrv@mojatatu.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).