From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D396AC43381 for ; Thu, 28 Mar 2019 02:12:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DD0B206C0 for ; Thu, 28 Mar 2019 02:12:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HcmKYNuN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727419AbfC1CMC (ORCPT ); Wed, 27 Mar 2019 22:12:02 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:36971 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbfC1CMC (ORCPT ); Wed, 27 Mar 2019 22:12:02 -0400 Received: by mail-pf1-f196.google.com with SMTP id 8so10600945pfr.4 for ; Wed, 27 Mar 2019 19:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wl6iaEyViIJwlXj8n8AWENyr37igxM7grHuy0SZ3LOk=; b=HcmKYNuN9NOAg7bqaNbCZsX3AErWfifLhI8gdwGk2Vc9N9NkfExyGCpdrhaqTI3zA5 OFpp9jK5npYh2wrbwhn815KaNo0Xx3Q75BMFcL5iD9CtOm7cxYL5Jr63uV/nNEjA8k6p sTryUFHtuul31zcnfHMAYJTRZ+RlbgeuGWSyDXU8ZiS6I+butWWkEUlK4MvYcpOpmpX7 C9k3CRClOD4ODs8cGF5KuzqQ1NplmsIJAoT03gmHo4jZKDPMC48VDXUYIAjDHtq7KRk+ eE3iuePJI5S0KPjXDivM0uyYTb7aBK1kLmG0XctrzDOF28jijxqIHsewNj2MX34ZvBoa HBgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wl6iaEyViIJwlXj8n8AWENyr37igxM7grHuy0SZ3LOk=; b=QUKV0uHPBlxNPO2YZV12pq5nn7X4D0rodUuUAW28bMbbxUwrwf23xuMjZRSf+1UtNE 51XX73WXNLmaO1ONw2io9S4FIGTZKzlXJP8sOhm2zap2Vh2g6O1y97qJEJHY3/6pAGL3 oueKyPTRtQKZ2XrfWp2Kp1KOGgKijEyKMP3A92dbk132gjqB5+uUfNmDvipxCe8GU7mH STPcO5aD439WhmtyzSwFbd5VXNYoThnTtw8Vf/K2pXQBL6wBEF1hZrYBZ1T/PjdROcwc LbFd9EcF3KcWtfx+8VGf4S8xcF6bcZauQ5yYp81GN5vMfj3TXx6yfJLCdq2YlOZerCCy hPZQ== X-Gm-Message-State: APjAAAUTjpoo9U4zzU9eH7jnH/ls7YsOcLhhcV3CUpAZ+dlu4jaKSRso iWE/+RP3U+vjH2Dx77RJX/Y= X-Google-Smtp-Source: APXvYqzXcrzgS7R9JMP2OvHkv5jIlqHfPzgWE3E87w1ChwerBnii4ACnHwbdohM9R6/ISFMSAHZJuQ== X-Received: by 2002:a63:5659:: with SMTP id g25mr37869606pgm.436.1553739121880; Wed, 27 Mar 2019 19:12:01 -0700 (PDT) Received: from ?IPv6:2601:284:8200:5cfb:3c44:c5bd:e28a:98ee? ([2601:284:8200:5cfb:3c44:c5bd:e28a:98ee]) by smtp.googlemail.com with ESMTPSA id d11sm9807539pgq.6.2019.03.27.19.12.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 19:12:01 -0700 (PDT) Subject: Re: [PATCH v2 net-next 05/13] ipv6: Create init helper for fib6_nh To: Alexei Starovoitov Cc: David Ahern , davem@davemloft.net, netdev@vger.kernel.org, idosch@mellanox.com, jiri@mellanox.com, saeedm@mellanox.com References: <20190327182329.18149-1-dsahern@kernel.org> <20190327182329.18149-6-dsahern@kernel.org> <20190327225210.kbpivej33a72adwq@ast-mbp> <8e0e2afc-c8e7-8728-7b4d-f9c64987d46a@gmail.com> <20190328013051.cukjdmcfdc5gmxnv@ast-mbp> From: David Ahern Message-ID: <8561a60a-0fbb-ff9e-6bf4-c82c69ebd5b6@gmail.com> Date: Wed, 27 Mar 2019 20:11:59 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190328013051.cukjdmcfdc5gmxnv@ast-mbp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/27/19 7:30 PM, Alexei Starovoitov wrote: > cfg should really be const. and BTW, it is not const now to ip6_route_info_create and making it const affects a long list of helper functions invoked by now fib6_nh_init.