From: Heiner Kallweit <hkallweit1@gmail.com>
To: Phil Reid <preid@electromag.com.au>, David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: stmmac: Remove wrong message in stmmac_probe_config_dt
Date: Thu, 2 Feb 2017 08:18:03 +0100 [thread overview]
Message-ID: <857627f0-0e4d-e5ba-68d6-b29e85fcdd88@gmail.com> (raw)
In-Reply-To: <1ceefa8c-c7ca-1927-810d-2dcf3c3f0a82@electromag.com.au>
Am 02.02.2017 um 03:20 schrieb Phil Reid:
> On 2/02/2017 05:05, Heiner Kallweit wrote:
>> I can only imagine that this message ended up there by a copy & paste
>> mistake. The same message appears correctly a few lines later, but
>> here it doesn't make sense.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> index 460f94f5..5edf23dc 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> @@ -371,7 +371,6 @@ stmmac_probe_config_dt(struct platform_device *pdev, const char **mac)
>> } else {
>> clk_prepare_enable(plat->clk_ptp_ref);
>> plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref);
>> - dev_info(&pdev->dev, "No reset control found\n");
>> }
>>
>> plat->stmmac_rst = devm_reset_control_get(&pdev->dev,
>>
>
> It was originally:
> netdev_dbg(priv->dev, "PTP rate %d\n", priv->clk_ptp_rate);
> Before it got moved in:
> commit f573c0b9c4e02691cf87736bd0824fd37ec02e65
> stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure
>
Thanks for the hint, I'll send a v2 to restore the original message.
prev parent reply other threads:[~2017-02-02 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 21:05 [PATCH] net: stmmac: Remove wrong message in stmmac_probe_config_dt Heiner Kallweit
2017-02-02 2:20 ` Phil Reid
2017-02-02 7:18 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857627f0-0e4d-e5ba-68d6-b29e85fcdd88@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=preid@electromag.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).