From: Florian Fainelli <f.fainelli@gmail.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
"David S. Miller" <davem@davemloft.net>,
Zach Brown <zach.brown@ni.com>,
Volodymyr Bendiuga <volodymyr.bendiuga@gmail.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Magnus Öberg" <magnus.oberg@westermo.se>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net: phy: leds: Clear phy_num_led_triggers on failure to avoid crash
Date: Tue, 24 Jan 2017 12:52:02 -0800 [thread overview]
Message-ID: <858caf82-b49e-96d9-98a5-32be915c3f74@gmail.com> (raw)
In-Reply-To: <1485272470-3497-2-git-send-email-geert+renesas@glider.be>
On 01/24/2017 07:41 AM, Geert Uytterhoeven wrote:
> phy_attach_direct() ignores errors returned by
> phy_led_triggers_register(). I think that's OK, as LED triggers can be
> considered a non-critical feature.
>
> However, this causes problems later:
> - phy_led_trigger_change_speed() will access the array
> phy_device.phy_led_triggers, which has been freed in the error path
> of phy_led_triggers_register(), which may lead to a crash.
>
> - phy_led_triggers_unregister() will access the same array, leading to
> crashes during s2ram or poweroff, like:
>
> Unable to handle kernel NULL pointer dereference at virtual address
> 00000000
> ...
> [<c04116d4>] (__list_del_entry_valid) from [<c05e8948>] (led_trigger_unregister+0x34/0xcc)
> [<c05e8948>] (led_trigger_unregister) from [<c05336c4>] (phy_led_triggers_unregister+0x28/0x34)
> [<c05336c4>] (phy_led_triggers_unregister) from [<c0531d44>] (phy_detach+0x30/0x74)
> [<c0531d44>] (phy_detach) from [<c0538bdc>] (sh_eth_close+0x64/0x9c)
> [<c0538bdc>] (sh_eth_close) from [<c04d4ce0>] (dpm_run_callback+0x48/0xc8)
>
> or:
>
> list_del corruption. prev->next should be dede6540, but was 2e323931
> ------------[ cut here ]------------
> kernel BUG at lib/list_debug.c:52!
> ...
> [<c02f6d70>] (__list_del_entry_valid) from [<c0425168>] (led_trigger_unregister+0x34/0xcc)
> [<c0425168>] (led_trigger_unregister) from [<c03a05a0>] (phy_led_triggers_unregister+0x28/0x34)
> [<c03a05a0>] (phy_led_triggers_unregister) from [<c039ec04>] (phy_detach+0x30/0x74)
> [<c039ec04>] (phy_detach) from [<c03a4fc0>] (sh_eth_close+0x6c/0xa4)
> [<c03a4fc0>] (sh_eth_close) from [<c0483234>] (__dev_close_many+0xac/0xd0)
>
> To fix this, clear phy_device.phy_num_led_triggers in the error path of
> phy_led_triggers_register() fails.
>
> Note that the "No phy led trigger registered for speed" message will
> still be printed on link speed changes, which is a good cue that
> something went wrong with the LED triggers.
>
> Fixes: 2e0bc452f4721520 ("net: phy: leds: add support for led triggers on phy link state change")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2017-01-24 20:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 15:41 [PATCH 0/2] net: phy: leds: Fix truncated LED trigger names and crashes Geert Uytterhoeven
2017-01-24 15:41 ` [PATCH 1/2] net: phy: leds: Clear phy_num_led_triggers on failure to avoid crash Geert Uytterhoeven
2017-01-24 20:52 ` Florian Fainelli [this message]
2017-01-24 15:41 ` [PATCH 2/2] net: phy: leds: Fix truncated LED trigger names Geert Uytterhoeven
2017-01-24 20:03 ` Andrew Lunn
2017-01-25 9:56 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=858caf82-b49e-96d9-98a5-32be915c3f74@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.oberg@westermo.se \
--cc=netdev@vger.kernel.org \
--cc=volodymyr.bendiuga@gmail.com \
--cc=zach.brown@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).