From: Qingfang Deng <qingfang.deng@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>, Hyunwoo Kim <imv4bel@gmail.com>
Cc: dhowells@redhat.com, marc.dionne@auristor.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
horms@kernel.org, linux-afs@lists.infradead.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net] rxrpc: Also unshare DATA/RESPONSE packets when paged frags are present
Date: Sat, 9 May 2026 09:32:06 +0800 [thread overview]
Message-ID: <85cac832-64f1-4968-abcc-460b8df8918b@linux.dev> (raw)
In-Reply-To: <20260508132532.2008a68f@kernel.org>
On 2026/5/9 4:25, Jakub Kicinski wrote:
> On Fri, 8 May 2026 15:07:49 +0900 Hyunwoo Kim wrote:
>>>> - if (skb_cloned(skb)) {
>>>> + if (skb_cloned(skb) || skb->data_len) {
>>> Ditto.
>> Thank you for the review.
> Maybe skb_ensure_writable() ?
This also works, but has a subtle difference that a new buffer is
allocated with GFP_ATOMIC instead of GFP_NOFS.
prev parent reply other threads:[~2026-05-09 1:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 23:35 [PATCH net] rxrpc: Also unshare DATA/RESPONSE packets when paged frags are present Hyunwoo Kim
2026-05-01 15:58 ` Simon Horman
2026-05-01 16:57 ` Hyunwoo Kim
2026-05-08 5:57 ` Qingfang Deng
2026-05-08 6:07 ` Hyunwoo Kim
2026-05-08 20:25 ` Jakub Kicinski
2026-05-09 1:32 ` Qingfang Deng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85cac832-64f1-4968-abcc-460b8df8918b@linux.dev \
--to=qingfang.deng@linux.dev \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=imv4bel@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox