From: Florian Fainelli <f.fainelli@gmail.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 3/4] net: dsa: setup master ethtool after dsa_ptr
Date: Tue, 19 Sep 2017 10:49:52 -0700 [thread overview]
Message-ID: <85ebc3f7-b8b1-a2e4-f0e4-32c309857730@gmail.com> (raw)
In-Reply-To: <20170919155700.14474-4-vivien.didelot@savoirfairelinux.com>
On 09/19/2017 08:56 AM, Vivien Didelot wrote:
> DSA overrides the master's ethtool ops so that we can inject its CPU
> port's statistics. Because of that, we need to setup the ethtool ops
> after the master's dsa_ptr pointer has been assigned, not before.
Yes, good point, technically this is a bugfix, but since we have changed
this quite often and the race is tiny, I am not positive we could a)
trigger this in real life, and b) provide a proper Fixes tag.
>
> This patch setups the ethtool ops after dsa_ptr is assigned, and
> restores them before it gets cleared.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2017-09-19 17:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 15:56 [PATCH net-next 0/4] net: dsa: move master ethtool code Vivien Didelot
2017-09-19 15:56 ` [PATCH net-next 1/4] net: dsa: remove copy of master ethtool_ops Vivien Didelot
2017-09-19 19:55 ` Florian Fainelli
2017-09-19 15:56 ` [PATCH net-next 2/4] net: dsa: setup master ethtool unconditionally Vivien Didelot
2017-09-19 17:48 ` Florian Fainelli
2017-09-19 15:56 ` [PATCH net-next 3/4] net: dsa: setup master ethtool after dsa_ptr Vivien Didelot
2017-09-19 17:49 ` Florian Fainelli [this message]
2017-09-19 15:57 ` [PATCH net-next 4/4] net: dsa: move master ethtool code Vivien Didelot
2017-09-19 19:56 ` Florian Fainelli
2017-09-19 20:04 ` [PATCH net-next 0/4] " Florian Fainelli
2017-09-19 23:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85ebc3f7-b8b1-a2e4-f0e4-32c309857730@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).