From: Shannon Nelson <shannon.nelson@oracle.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com,
steffen.klassert@secunet.com, sowmini.varadhan@oracle.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 next-queue 05/10] ixgbe: add ipsec offload add and remove SA
Date: Wed, 20 Dec 2017 17:39:13 -0800 [thread overview]
Message-ID: <85fe1cd2-e935-52dc-e36b-0973e4c03653@oracle.com> (raw)
In-Reply-To: <20171221010139.GM6122@localhost.localdomain>
On 12/20/2017 5:17 PM, Marcelo Ricardo Leitner wrote:
> Hi,
>
> On Tue, Dec 19, 2017 at 03:59:57PM -0800, Shannon Nelson wrote:
>> +}
>> +
>> +static const struct xfrmdev_ops ixgbe_xfrmdev_ops = {
>> + .xdo_dev_state_add = ixgbe_ipsec_add_sa,
>> + .xdo_dev_state_delete = ixgbe_ipsec_del_sa,
>> +};
>> +
>
> This struct is only declared if XFRM_OFFLOAD is selected. What is
> selecting it for ixgbe driver?
> mlx5 driver has an extra option for ipsec offload and it then does
> 'depends on XFRM_OFFLOAD'
>
> Marcelo
>
I didn't bother putting a 'depends' item in the ixgbe's Kconfig entry,
and I didn't create an extra CONFIG variable to enable ixgbe's support
of the offload. If CONFIG_XFRM_OFFLOAD is set, then ixgbe will support it.
sln
next prev parent reply other threads:[~2017-12-21 1:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 23:59 [PATCH v3 next-queue 00/10] ixgbe: Add ipsec offload Shannon Nelson
2017-12-19 23:59 ` [PATCH v3 next-queue 01/10] ixgbe: clean up ipsec defines Shannon Nelson
2017-12-19 23:59 ` [PATCH v3 next-queue 02/10] ixgbe: add ipsec register access routines Shannon Nelson
2017-12-19 23:59 ` [PATCH v3 next-queue 03/10] ixgbe: add ipsec engine start and stop routines Shannon Nelson
2017-12-19 23:59 ` [PATCH v3 next-queue 04/10] ixgbe: add ipsec data structures Shannon Nelson
2017-12-19 23:59 ` [PATCH v3 next-queue 05/10] ixgbe: add ipsec offload add and remove SA Shannon Nelson
2017-12-21 1:17 ` Marcelo Ricardo Leitner
2017-12-21 1:39 ` Shannon Nelson [this message]
2017-12-21 2:21 ` Marcelo Ricardo Leitner
2017-12-21 3:30 ` Shannon Nelson
2017-12-19 23:59 ` [PATCH v3 next-queue 06/10] ixgbe: restore offloaded SAs after a reset Shannon Nelson
2017-12-19 23:59 ` [PATCH v3 next-queue 07/10] ixgbe: process the Rx ipsec offload Shannon Nelson
2017-12-20 0:00 ` [PATCH v3 next-queue 08/10] ixgbe: process the Tx " Shannon Nelson
2017-12-22 8:24 ` Yanjun Zhu
2017-12-22 22:33 ` Shannon Nelson
2017-12-20 0:00 ` [PATCH v3 next-queue 09/10] ixgbe: ipsec offload stats Shannon Nelson
2017-12-20 0:00 ` [PATCH v3 next-queue 10/10] ixgbe: register ipsec offload with the xfrm subsystem Shannon Nelson
2017-12-21 6:39 ` [PATCH v3 next-queue 00/10] ixgbe: Add ipsec offload Yanjun Zhu
2017-12-21 7:09 ` Yanjun Zhu
2017-12-21 17:55 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85fe1cd2-e935-52dc-e36b-0973e4c03653@oracle.com \
--to=shannon.nelson@oracle.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sowmini.varadhan@oracle.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).