From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roman Mashak <mrv@mojatatu.com>
Subject: Re: [PATCH iproute2 1/1] ss: add missing path MTU parameter
Date: Thu, 14 Dec 2017 14:51:39 -0500
Message-ID: <85k1xpulys.fsf@mojatatu.com>
References: <1513279438-15045-1-git-send-email-mrv@mojatatu.com>
        <CADVnQynM6HX-q-ZA=XiGEcOjU6U5LyVxTqkcE87Vbfoo2mrf-g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: Stephen Hemminger <stephen@networkplumber.org>,
        Netdev <netdev@vger.kernel.org>,
        Jamal Hadi Salim <jhs@mojatatu.com>
To: Neal Cardwell <ncardwell@google.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-it0-f51.google.com ([209.85.214.51]:45548 "EHLO
        mail-it0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752038AbdLNTvl (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 14 Dec 2017 14:51:41 -0500
Received: by mail-it0-f51.google.com with SMTP id z6so14079220iti.4
        for <netdev@vger.kernel.org>; Thu, 14 Dec 2017 11:51:40 -0800 (PST)
In-Reply-To: <CADVnQynM6HX-q-ZA=XiGEcOjU6U5LyVxTqkcE87Vbfoo2mrf-g@mail.gmail.com>
        (Neal Cardwell's message of "Thu, 14 Dec 2017 14:32:00 -0500")
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Neal Cardwell <ncardwell@google.com> writes:

> On Thu, Dec 14, 2017 at 2:23 PM, Roman Mashak <mrv@mojatatu.com> wrote:
>>
>> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
>> ---
> ...
>> @@ -1967,6 +1968,8 @@ static void tcp_stats_print(struct tcpstat *s)
>>                 printf(" cwnd:%u", s->cwnd);
>>         if (s->ssthresh)
>>                 printf(" ssthresh:%d", s->ssthresh);
>> +       if (s->pmtu)
>> +               printf(" pmtu:%u", s->pmtu);
>
> Would it be possible to print the pmtu immediately after the mss? IMHO
> having related parameters next to each other this way would make this
> easier to parse for humans.
>
> Thanks for adding this!

Sure, I will send v2 with change.