From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5788C606C1 for ; Mon, 8 Jul 2019 16:04:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82B4C20656 for ; Mon, 8 Jul 2019 16:04:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mojatatu-com.20150623.gappssmtp.com header.i=@mojatatu-com.20150623.gappssmtp.com header.b="0HhWV88/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390910AbfGHQER (ORCPT ); Mon, 8 Jul 2019 12:04:17 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:41928 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388618AbfGHQER (ORCPT ); Mon, 8 Jul 2019 12:04:17 -0400 Received: by mail-io1-f68.google.com with SMTP id j5so17076317ioj.8 for ; Mon, 08 Jul 2019 09:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iiP9tfmmaTKzDJS1wt7DSWmvbLx0+id24UTIL9u4ZG0=; b=0HhWV88/jMTXJI/TnglAc+2udqzUHgLuw78rXKiZM0NAlTDZ1t8VxNt6EXKIzaLF+L jA0KJcJrfiridojd56BxXtmhiG9POb+putY0Bw0iZofjgzv7YlsODd2QMIAIASHsT//t IJh5ojgQFK+czUNOu2bWCNCRzofJO2ec9sRWEhW2+iwfBkQ+UiqMzSonbdJ4jQYnfDJq pc3AJ5yeu5uDM9Yp00OCHLCILSYDM360Kf4WjKF0XLK2fL0b73mQ6ihonVHxSBkNMbG+ Dk/vlI/2dn3qMYZrjYqEywkQfTkjif8fGxDhe9VS5fV9RJt1MqCXQJ0kAoq/mNWGBNqy B/eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=iiP9tfmmaTKzDJS1wt7DSWmvbLx0+id24UTIL9u4ZG0=; b=RdMYAXE6fF7Va7zG8wKpqBrLkzRmewr+pveQp5QSx1sRrgb47I5yX69A6vcfoXrWEA kAVf2wJpoqrFdrvtISDqUxDxlhz1d4ZbnClXJ5HCDrBtXTs2mra+Jy83RA0LdYFfKg7c 9w7CWWJw5mZe1xmvgMoYB4Hitgf5MHzb5MZ41IRytlqFgddKdFEuT3MgqXtfZ9wGC+mc r42JRejXSWnfI0hoMQmcnI+V6C9C7BE711q4SvHdWap3I0T1+nIE6KJmmjJexgLWX0di KZJhAZK+5GicrPbBx22QIdpclKLqSfeEZyvHvt99xxncYxMJ7a3lbD6XH2OD2rChwXHM A1OQ== X-Gm-Message-State: APjAAAUmTf1Iz6iyIq70emTfTjsf2iKTGLahwgxYnJFX25sRy9i036lS 8Vha8QisSC5UAt7bCoQzX17G3A== X-Google-Smtp-Source: APXvYqw2axo45PrFD+as9cANYa2HVDRJdrVwOnvvzR5XG11KvJT1AWmZQwe7LpUObubFhLG+R6Nevw== X-Received: by 2002:a5d:940b:: with SMTP id v11mr3815535ion.69.1562601856858; Mon, 08 Jul 2019 09:04:16 -0700 (PDT) Received: from sevai ([64.26.149.125]) by smtp.gmail.com with ESMTPSA id z26sm19683231ioi.85.2019.07.08.09.04.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2019 09:04:16 -0700 (PDT) From: Roman Mashak To: Stephen Hemminger Cc: netdev@vger.kernel.org, kernel@mojatatu.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us Subject: Re: [PATCH iproute2 1/2] tc: added mask parameter in skbedit action References: <1562195132-9829-1-git-send-email-mrv@mojatatu.com> <20190708081501.665e7ddb@hermes.lan> Date: Mon, 08 Jul 2019 12:04:15 -0400 In-Reply-To: <20190708081501.665e7ddb@hermes.lan> (Stephen Hemminger's message of "Mon, 8 Jul 2019 08:15:01 -0700") Message-ID: <85muho5x8g.fsf@mojatatu.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Stephen Hemminger writes: > On Wed, 3 Jul 2019 19:05:31 -0400 > Roman Mashak wrote: > >> + if (tb[TCA_SKBEDIT_MASK]) { >> + print_uint(PRINT_ANY, "mask", "/0x%x", >> + rta_getattr_u32(tb[TCA_SKBEDIT_MASK])); > > Why not print in hex with. > > print_hex(PRINT_ANY, "mask", "/%#x", > rta_getattr_u32(tb[TCA_SKBEDIT_MASK])); Sure, I will send v2.