From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Mashak Subject: Re: [PATCH net-next 1/1] net sched qdisc: pass netlink message flags in event notification Date: Sat, 28 Oct 2017 23:36:41 -0400 Message-ID: <85mv4atyk6.fsf@mojatatu.com> References: <1509054014-23254-1-git-send-email-mrv@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain Cc: David Miller , Linux Kernel Network Developers , Jamal Hadi Salim , Jiri Pirko To: Cong Wang Return-path: Received: from mail-io0-f193.google.com ([209.85.223.193]:44554 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751524AbdJ2Dgp (ORCPT ); Sat, 28 Oct 2017 23:36:45 -0400 Received: by mail-io0-f193.google.com with SMTP id m16so20339069iod.1 for ; Sat, 28 Oct 2017 20:36:45 -0700 (PDT) In-Reply-To: (Cong Wang's message of "Fri, 27 Oct 2017 14:55:05 -0700") Sender: netdev-owner@vger.kernel.org List-ID: Cong Wang writes: > On Thu, Oct 26, 2017 at 2:40 PM, Roman Mashak wrote: >> Userland client should be able to read an event, and reflect it back to >> the kernel, therefore it needs to extract complete set of netlink flags. >> >> For example, this will allow "tc monitor" to distinguish Add and Replace >> qdisc operations. >> >> Signed-off-by: Roman Mashak >> --- >> net/sched/sch_api.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c >> index a9ac912..e3e29be 100644 >> --- a/net/sched/sch_api.c >> +++ b/net/sched/sch_api.c >> @@ -859,7 +859,7 @@ static int qdisc_notify(struct net *net, struct sk_buff *oskb, >> } >> if (new && !tc_qdisc_dump_ignore(new, false)) { >> if (tc_fill_qdisc(skb, new, clid, portid, n->nlmsg_seq, >> - old ? NLM_F_REPLACE : 0, RTM_NEWQDISC) < 0) >> + n->nlmsg_flags, RTM_NEWQDISC) < 0) > > > Don't you want to change the other tc_fill_qdisc() in the same function > too? ;) The other tc_fill_qdisc generates RTM_DELQDISC event, in that case netlink flags for user don't matter.