From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f193.google.com ([209.85.223.193]:45578 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967496AbeCSSkU (ORCPT ); Mon, 19 Mar 2018 14:40:20 -0400 Received: by mail-io0-f193.google.com with SMTP id 141so1467373iou.12 for ; Mon, 19 Mar 2018 11:40:20 -0700 (PDT) From: Roman Mashak To: Davide Caratti Cc: netdev@vger.kernel.org, "David S. Miller" , "Brenda J . Butler" Subject: Re: [PATCH net-next] tc-testing: add selftests for 'bpf' action References: <14be6cc1ace745b6ee37e552bc0e317e7ae765ec.1521418521.git.dcaratti@redhat.com> Date: Mon, 19 Mar 2018 14:40:18 -0400 In-Reply-To: <14be6cc1ace745b6ee37e552bc0e317e7ae765ec.1521418521.git.dcaratti@redhat.com> (Davide Caratti's message of "Mon, 19 Mar 2018 01:19:08 +0100") Message-ID: <85po3zgb8t.fsf@mojatatu.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org List-ID: Davide Caratti writes: > Test d959: Add cBPF action with valid bytecode > Test f84a: Add cBPF action with invalid bytecode > Test e939: Add eBPF action with valid object-file > Test d819: Replace cBPF bytecode and action control > Test 6ae3: Delete cBPF action > Test 3e0d: List cBPF actions > Test 55ce: Flush BPF actions > Test ccc3: Add cBPF action with duplicate index > > Signed-off-by: Davide Caratti > --- > .../selftests/tc-testing/tc-tests/actions/bpf.json | 215 +++++++++++++++++++++ > 1 file changed, 215 insertions(+) > create mode 100644 tools/testing/selftests/tc-testing/tc-tests/actions/bpf.json > > diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/bpf.json b/tools/testing/selftests/tc-testing/tc-tests/actions/bpf.json > new file mode 100644 > index 000000000000..0295a63dd0c8 [...] Davide, thank you for efforts. Please also add a test for testing max index value (since it is u32 type) and a test with cookie (every action may have optional 128-bit value, that carries some user state and not intepreted by the kernel).