From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Mashak Subject: Re: [PATCH v3 iproute2 1/1] tc: fix conversion types when printing actions unsigned values Date: Tue, 27 Mar 2018 17:33:05 -0400 Message-ID: <85tvt1i4q6.fsf@mojatatu.com> References: <1521493541-31340-1-git-send-email-mrv@mojatatu.com> <20180327090234.5d457806@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us To: Stephen Hemminger Return-path: Received: from mail-io0-f169.google.com ([209.85.223.169]:41531 "EHLO mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbeC0VdG (ORCPT ); Tue, 27 Mar 2018 17:33:06 -0400 Received: by mail-io0-f169.google.com with SMTP id m83so1003236ioi.8 for ; Tue, 27 Mar 2018 14:33:06 -0700 (PDT) In-Reply-To: <20180327090234.5d457806@xeon-e3> (Stephen Hemminger's message of "Tue, 27 Mar 2018 09:02:34 -0700") Sender: netdev-owner@vger.kernel.org List-ID: Stephen Hemminger writes: > On Mon, 19 Mar 2018 17:05:41 -0400 > Roman Mashak wrote: > >> diff --git a/tc/m_gact.c b/tc/m_gact.c >> index 16c4413f4217..52022415db48 100644 >> --- a/tc/m_gact.c >> +++ b/tc/m_gact.c >> @@ -194,7 +194,7 @@ print_gact(struct action_util *au, FILE *f, struct rtattr *arg) >> print_string(PRINT_ANY, "random_type", "\n\t random type %s", >> prob_n2a(pp->ptype)); >> print_action_control(f, " ", pp->paction, " "); >> - print_int(PRINT_ANY, "val", "val %d", pp->pval); >> + print_int(PRINT_ANY, "val", "val %u", pp->pval); >> close_json_object(); > > This needs to be print_uint in order to work correctly with json output. > > Also, please consider doing json on all the match types in a later patch > for net-next. Did you mean iproute2-next?