From: Roman Mashak <mrv@mojatatu.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/1] net sched actions: rename act_get_notify() to tcf_get_notify()
Date: Wed, 05 Jul 2017 17:13:32 -0400 [thread overview]
Message-ID: <85wp7mfuyr.fsf@mojatatu.com> (raw)
In-Reply-To: <20170705203146.GA8974@nanopsycho> (Jiri Pirko's message of "Wed, 5 Jul 2017 22:31:46 +0200")
Jiri Pirko <jiri@resnulli.us> writes:
> Wed, Jul 05, 2017 at 09:33:58PM CEST, mrv@mojatatu.com wrote:
>>Make name consistent with other TC event notification routines.
>>
>>Signed-off-by: Roman Mashak <mrv@mojatatu.com>
>>---
>> net/sched/act_api.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>>diff --git a/net/sched/act_api.c b/net/sched/act_api.c
>>index aed6cf2..f2e9ed3 100644
>>--- a/net/sched/act_api.c
>>+++ b/net/sched/act_api.c
>>@@ -835,7 +835,7 @@ static int tca_get_fill(struct sk_buff *skb, struct list_head *actions,
>> }
>>
>> static int
>>-act_get_notify(struct net *net, u32 portid, struct nlmsghdr *n,
>>+tcf_get_notify(struct net *net, u32 portid, struct nlmsghdr *n,
>
> Rather call it "tcf_action_get_notify"
We already have tcf_add_notify() and tcf_del_notify() as a common style.
>
> + net-next is closed if I'm not mistaken
prev parent reply other threads:[~2017-07-05 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 19:33 [PATCH net-next 1/1] net sched actions: rename act_get_notify() to tcf_get_notify() Roman Mashak
2017-07-05 20:31 ` Jiri Pirko
2017-07-05 21:13 ` Roman Mashak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85wp7mfuyr.fsf@mojatatu.com \
--to=mrv@mojatatu.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).