From: Roman Mashak <mrv@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
kernel@mojatatu.com, Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net 1/1] net sched: fix reporting the first-time use timestamp
Date: Sun, 17 May 2020 21:10:17 -0400 [thread overview]
Message-ID: <85y2pqm4jq.fsf@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpXx-yBm2jQ57L+vkiU+hR4VExgzFrntw3R2HmOFpzF5Ug@mail.gmail.com> (Cong Wang's message of "Sun, 17 May 2020 11:47:18 -0700")
Cong Wang <xiyou.wangcong@gmail.com> writes:
> On Sun, May 17, 2020 at 5:47 AM Roman Mashak <mrv@mojatatu.com> wrote:
>>
>> When a new action is installed, firstuse field of 'tcf_t' is explicitly set
>> to 0. Value of zero means "new action, not yet used"; as a packet hits the
>> action, 'firstuse' is stamped with the current jiffies value.
>>
>> tcf_tm_dump() should return 0 for firstuse if action has not yet been hit.
>
> Your patch makes sense to me.
>
> Just one more thing, how about 'lastuse'? It is initialized with jiffies,
> not 0, it seems we should initialize it to 0 too, as it is not yet used?
Yes, exactly. I was planning to send a separate patch for this.
Thanks for review, Cong.
next prev parent reply other threads:[~2020-05-18 1:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 12:46 [PATCH net 1/1] net sched: fix reporting the first-time use timestamp Roman Mashak
2020-05-17 18:47 ` Cong Wang
2020-05-18 1:10 ` Roman Mashak [this message]
2020-05-18 12:43 ` Jamal Hadi Salim
2020-05-18 17:58 ` Cong Wang
2020-05-19 0:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85y2pqm4jq.fsf@mojatatu.com \
--to=mrv@mojatatu.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).