From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f196.google.com ([209.85.223.196]:44390 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030686AbeCSSOd (ORCPT ); Mon, 19 Mar 2018 14:14:33 -0400 Received: by mail-io0-f196.google.com with SMTP id h23so21906619iob.11 for ; Mon, 19 Mar 2018 11:14:33 -0700 (PDT) From: Roman Mashak To: Stephen Hemminger Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us Subject: Re: [PATCH iproute2 1/1] tc: fix conversion types when printing actions unsigned values References: <1521481807-20401-1-git-send-email-mrv@mojatatu.com> <20180319105526.67094dcd@xeon-e3> Date: Mon, 19 Mar 2018 14:14:31 -0400 In-Reply-To: <20180319105526.67094dcd@xeon-e3> (Stephen Hemminger's message of "Mon, 19 Mar 2018 10:55:26 -0700") Message-ID: <85y3ioexvc.fsf@mojatatu.com> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org List-ID: Stephen Hemminger writes: > On Mon, 19 Mar 2018 13:50:07 -0400 > Roman Mashak wrote: > >> Signed-off-by: Roman Mashak >> --- >> tc/m_action.c | 2 +- >> tc/m_gact.c | 2 +- >> tc/m_ife.c | 2 +- >> tc/m_pedit.c | 2 +- >> tc/m_sample.c | 6 +++--- >> tc/m_tunnel_key.c | 2 +- >> 6 files changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/tc/m_action.c b/tc/m_action.c >> index 148f1372d414..85c9d44c7e50 100644 >> --- a/tc/m_action.c >> +++ b/tc/m_action.c >> @@ -408,7 +408,7 @@ int print_action(const struct sockaddr_nl *who, >> if (tb[TCA_ROOT_COUNT]) >> tot_acts = RTA_DATA(tb[TCA_ROOT_COUNT]); >> >> - fprintf(fp, "total acts %d\n", tot_acts ? *tot_acts:0); >> + fprintf(fp, "total acts %u\n", tot_acts ? *tot_acts:0); > > Please add spaces around : in trigraph. > > When fixing code, it has to pass style checkers. Thanks, I will send v2.