From: Daniel Borkmann <daniel@iogearbox.net>
To: John Fastabend <john.fastabend@gmail.com>,
borkmann@iogearbox.net, alexei.starovoitov@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [bpf-net PATCH v2] bpf: sockmap missing NULL psock check
Date: Sun, 7 Jan 2018 00:08:18 +0100 [thread overview]
Message-ID: <860f27aa-38c2-8655-2dca-e6aca89c41f7@iogearbox.net> (raw)
In-Reply-To: <20180105040209.11195.85577.stgit@john-Precision-Tower-5810>
On 01/05/2018 05:02 AM, John Fastabend wrote:
> Add psock NULL check to handle a racing sock event that can get the
> sk_callback_lock before this case but after xchg happens causing the
> refcnt to hit zero and sock user data (psock) to be null and queued
> for garbage collection.
>
> Also add a comment in the code because this is a bit subtle and
> not obvious in my opinion.
>
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Applied to bpf, thanks John!
prev parent reply other threads:[~2018-01-06 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 4:02 [bpf-net PATCH v2] bpf: sockmap missing NULL psock check John Fastabend
2018-01-06 23:08 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=860f27aa-38c2-8655-2dca-e6aca89c41f7@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox