From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: Re: [PATCH net] ip6_tunnel: Don't update PMTU on tunnels with
 collect_md
Date: Fri, 12 Oct 2018 17:58:55 +0200
Message-ID: <8622979d-ea2d-82e2-600e-c0dd7d7e3e8a@6wind.com>
References: <5893664877d77075e32b33f72a7784f539555da0.1539266541.git.sbrivio@redhat.com>
Reply-To: nicolas.dichtel@6wind.com
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Alexei Starovoitov <ast@fb.com>, netdev@vger.kernel.org
To: Stefano Brivio <sbrivio@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f66.google.com ([209.85.221.66]:42237 "EHLO
        mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728537AbeJLXcG (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 12 Oct 2018 19:32:06 -0400
Received: by mail-wr1-f66.google.com with SMTP id g15-v6so13985264wru.9
        for <netdev@vger.kernel.org>; Fri, 12 Oct 2018 08:58:58 -0700 (PDT)
In-Reply-To: <5893664877d77075e32b33f72a7784f539555da0.1539266541.git.sbrivio@redhat.com>
Content-Language: fr
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Le 12/10/2018 à 14:32, Stefano Brivio a écrit :
> Commit 8d79266bc48c ("ip6_tunnel: add collect_md mode to IPv6
> tunnels") introduced a check to avoid updating PMTU when
> collect_md mode is enabled.
> 
> Later, commit f15ca723c1eb ("net: don't call update_pmtu
> unconditionally") dropped this check, I guess inadvertently.
I removed it because update_pmtu() is not set for md_dst_op, thus I assume this
check was done for that purpose.

Could you explain in your commit log which problem your patch fixes?