From mboxrd@z Thu Jan 1 00:00:00 1970 From: maowenan Subject: Re: [PATCH stable 4.4 1/9] Revert "tcp: detect malicious patterns in tcp_collapse_ofo_queue()" Date: Thu, 16 Aug 2018 09:55:42 +0800 Message-ID: <865f3aa5-e763-a5fe-9ab0-eab42e0fc310@huawei.com> References: <1534339268-111834-1-git-send-email-maowenan@huawei.com> <1534339268-111834-2-git-send-email-maowenan@huawei.com> <20180815131807.GA31330@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , , , , , To: Greg KH Return-path: Received: from szxga07-in.huawei.com ([45.249.212.35]:59469 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387553AbeHPEuy (ORCPT ); Thu, 16 Aug 2018 00:50:54 -0400 In-Reply-To: <20180815131807.GA31330@kroah.com> Sender: netdev-owner@vger.kernel.org List-ID: On 2018/8/15 21:18, Greg KH wrote: > On Wed, Aug 15, 2018 at 09:21:00PM +0800, Mao Wenan wrote: >> This reverts commit dc6ae4dffd656811dee7151b19545e4cd839d378. > > I need a reason why, and a signed-off-by line :( stable 4.4 only back port two patches to fix CVE-2018-5390, I have tested they can't fix fully because of simple queue used in lower version, so we need change simple queue to RB tree to finally resolve. But 9f5afeae have many conflicts with tcp: detect malicious patterns in tcp_collapse_ofo_queue() and tcp: avoid collapses in tcp_prune_queue() if possible, and there are patch series from Eric in mainline to fix CVE-2018-5390, so I need revert part of patches in stable 4.4 firstly, then apply 9f5afeae, and reapply five patches from Eric. 9f5afeae tcp: use an RB tree for ooo receive queue > > thanks, > > greg k-h > >