From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yinghai Lu" Subject: Re: MSI interrupts and disable_irq Date: Sun, 14 Oct 2007 16:15:46 -0700 Message-ID: <86802c440710141615g60fb9775oba590deb1a9fabde@mail.gmail.com> References: <46FC15A9.1070803@nvidia.com> <46FDBCB4.9090802@pobox.com> <4710901F.8010206@colorfullife.com> <86802c440710132259o6e82f6s4bed7b25bd5636e9@mail.gmail.com> <4711C217.2010605@colorfullife.com> <1192398473.6188.10.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Manfred Spraul" , "Jeff Garzik" , "Ayaz Abdulla" , nedev , "Linux Kernel Mailing List" , "David Miller" , "Andrew Morton" To: benh@kernel.crashing.org Return-path: Received: from wa-out-1112.google.com ([209.85.146.178]:32817 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756744AbXJNXPq (ORCPT ); Sun, 14 Oct 2007 19:15:46 -0400 Received: by wa-out-1112.google.com with SMTP id v27so1748315wah for ; Sun, 14 Oct 2007 16:15:46 -0700 (PDT) In-Reply-To: <1192398473.6188.10.camel@pasglop> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 10/14/07, Benjamin Herrenschmidt wrote: > > On Sun, 2007-10-14 at 09:15 +0200, Manfred Spraul wrote: > > Yinghai Lu wrote: > > > On 10/13/07, Manfred Spraul wrote: > > > > > >> Someone around with a MSI capable board? The forcedeth driver does > > >> dev->irq = pci_dev->irq > > >> in nv_probe(), especially before pci_enable_msi(). > > >> Does pci_enable_msi() change pci_dev->irq? Then we would disable the > > >> wrong interrupt.... > > >> > > > > > > the request_irq==>setup_irq will make dev->irq = pci_dev->irq. > > > > > > > > Where is that? > > Otherwise I would propose the attached patch. My board is not > > MSI-capable, thus I can't test it myself. > > Why not just copy pcidev->irq to dev->irq once ? it seems e1000 is using np->pci_dev->irq directly too. YH