From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 920E5C61CE8 for ; Sat, 19 Jan 2019 09:30:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DD7C2086A for ; Sat, 19 Jan 2019 09:30:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qj/73xP/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727688AbfASJak (ORCPT ); Sat, 19 Jan 2019 04:30:40 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:54678 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727644AbfASJaj (ORCPT ); Sat, 19 Jan 2019 04:30:39 -0500 Received: by mail-wm1-f68.google.com with SMTP id a62so6604116wmh.4 for ; Sat, 19 Jan 2019 01:30:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=7wKav4V4xZcYerKxfIM/YgXHcBChdGs//i7Npu9k0K8=; b=qj/73xP/t82UhQPoSTY/Cfc9ulDRpxvPOdzb9TwqBWIk6V+mov1YjiwIARYf+VV2Aw pkXZKVCXlpd8NxK8d8u+C0BOmWz7KIZIuDTrDZC7cxaZ/i+bT2eu7s+H2hNRTcrkftSy NobKjUL1n/ouAOEwJObmF4go+I7O5rbWTzqV9M8Mof5MHXX0Eh9ZhfXCChJPMN48y6fT wy8NqC7BPmJGf/eaVY8r+mUq7m22pNDL61NQ9GUe/rwmBywK5v3Tj7A4zZyQTNK9c63w rtJj8NsOaL069012hMBRaz/LH1xMqGqT5EyECfQQsmxfiRDZNVHwnoD6FrhPwtpal9qb iOqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=7wKav4V4xZcYerKxfIM/YgXHcBChdGs//i7Npu9k0K8=; b=YxIL2bgcetIGNLSC49z98Fgu2aU67kjKxzkmZbUjUFUcTZPZ0mtSEn5d884C95/G+m YxfE8Sje3spGdl7s8dvEwTralm2pkxo6FJ18UEoU0HSl3rvJw3fbmRXVXZZ3cF5vaebi iq/6T5+WAMVtCw70lm5R11ONkV/TEsYNOUEdXgl+4pwyRQGT+YagvASXCWBWlx65rj9f Rl7jUXb39YhGne6FQOmQgoPTOQ6S/HPXtBjtEL91g1NXytqaPHCFLvhuJ2sPaEdDNl2z OopPlh/LZs77mcoq6c5/iQQWfRCc0+sFyRsvC/QuT4gAf0pUQHxKpLrB/DN1BXSw9PPt u5Mg== X-Gm-Message-State: AJcUukdPnGlqwLIBg04BwwlN3lU4r+VwZJrwoJAHni80LNlx3MDjRODa R76buUo0pew2Co/mDNfuU55TKIxF X-Google-Smtp-Source: ALg8bN4yVc4eTSy6lFGL2ogxVf6wXYWfhq+BkCEflrCFk1Fa1bUB637LtxZB43zWVu659h9nmWUCtA== X-Received: by 2002:a1c:7c05:: with SMTP id x5mr17893519wmc.54.1547890237182; Sat, 19 Jan 2019 01:30:37 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:5cdd:5de5:6c17:efb0? (p200300EA8BF1E2005CDD5DE56C17EFB0.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:5cdd:5de5:6c17:efb0]) by smtp.googlemail.com with ESMTPSA id r77sm56417620wmd.22.2019.01.19.01.30.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Jan 2019 01:30:36 -0800 (PST) From: Heiner Kallweit Subject: [PATCH net-next] net: phy: fix issue with loading PHY driver w/o initramfs To: Krzysztof Kozlowski , Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" Message-ID: <8699eccc-4a12-09d2-5322-4e2533215258@gmail.com> Date: Sat, 19 Jan 2019 10:30:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org It was reported that on a system with nfsboot and w/o initramfs network fails because trying to load the PHY driver returns -ENOENT. Reason was that due to missing initramfs the modprobe binary isn't available. So we have to ignore error code -ENOENT. Fixes: 13d0ab6750b2 ("net: phy: check return code when requesting PHY driver module") Reported-by: Krzysztof Kozlowski Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy_device.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 264312137..1a12acfd9 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -552,10 +552,12 @@ static int phy_request_driver_module(struct phy_device *dev, int phy_id) ret = request_module(MDIO_MODULE_PREFIX MDIO_ID_FMT, MDIO_ID_ARGS(phy_id)); - /* we only check for failures in executing the usermode binary, - * not whether a PHY driver module exists for the PHY ID + /* We only check for failures in executing the usermode binary, + * not whether a PHY driver module exists for the PHY ID. + * Accept -ENOENT because this may occur in case no initramfs exists, + * then modprobe isn't available. */ - if (IS_ENABLED(CONFIG_MODULES) && ret < 0) { + if (IS_ENABLED(CONFIG_MODULES) && ret < 0 && ret != -ENOENT) { phydev_err(dev, "error %d loading PHY driver module for ID 0x%08x\n", ret, phy_id); return ret; -- 2.20.1