From: Florian Fainelli <f.fainelli@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"Jianming.qiao" <jqiaoulk@gmail.com>
Cc: davem@davemloft.net, eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v7 net-next] net: systemport: Support 64bit statistics
Date: Thu, 3 Aug 2017 16:20:04 -0700 [thread overview]
Message-ID: <86aaa85f-ddf3-0904-4d9a-c4edb82e3922@gmail.com> (raw)
In-Reply-To: <20170803161604.4d3d5ea1@xeon-e3>
On 08/03/2017 04:16 PM, Stephen Hemminger wrote:
> On Fri, 4 Aug 2017 00:07:45 +0100
> "Jianming.qiao" <jqiaoulk@gmail.com> wrote:
>
>> static const struct bcm_sysport_stats bcm_sysport_gstrings_stats[] = {
>> /* general stats */
>> - STAT_NETDEV(rx_packets),
>> - STAT_NETDEV(tx_packets),
>> - STAT_NETDEV(rx_bytes),
>> - STAT_NETDEV(tx_bytes),
>> + STAT_NETDEV64(rx_packets),
>> + STAT_NETDEV64(tx_packets),
>> + STAT_NETDEV64(rx_bytes),
>> + STAT_NETDEV64(tx_bytes),
>> STAT_NETDEV(rx_errors),
>
> Please don't duplicate regular statistics (ie netdev) into ethtool.
> It is a needless duplication.
Agreed, but these are there already and this driver's ethtool::get_stats
is an user ABI of some sort, is not it?
--
Florian
next prev parent reply other threads:[~2017-08-03 23:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 23:07 [PATCH v7 net-next] net: systemport: Support 64bit statistics Jianming.qiao
2017-08-03 23:16 ` Stephen Hemminger
2017-08-03 23:20 ` Florian Fainelli [this message]
2017-08-03 23:45 ` David Miller
2017-08-07 4:21 ` David Miller
2017-08-18 23:27 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86aaa85f-ddf3-0904-4d9a-c4edb82e3922@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jqiaoulk@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).