From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Wragg Subject: Re: [PATCH net v2 2/3] geneve: Relax MTU constraints Date: Thu, 18 Feb 2016 16:54:14 +0000 Message-ID: <86bn7e2c3t.fsf@weave.works> References: <1455036424-6403-1-git-send-email-david@weave.works> <1455036424-6403-3-git-send-email-david@weave.works> <86a8n86bcs.fsf@weave.works> <86vb5o3kd5.fsf@weave.works> Mime-Version: 1.0 Content-Type: text/plain Cc: Jesse Gross , Linux Kernel Network Developers , ovs dev , David Miller , Hannes Frederic Sowa , Thomas Graf , Roopa Prabhu To: Tom Herbert Return-path: Received: from mail-wm0-f54.google.com ([74.125.82.54]:35244 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270AbcBRQyQ (ORCPT ); Thu, 18 Feb 2016 11:54:16 -0500 Received: by mail-wm0-f54.google.com with SMTP id c200so37522712wme.0 for ; Thu, 18 Feb 2016 08:54:16 -0800 (PST) In-Reply-To: (Tom Herbert's message of "Tue, 16 Feb 2016 08:44:02 -0800") Sender: netdev-owner@vger.kernel.org List-ID: Tom Herbert writes: > Please implement like in ip_tunnel_change_mtu (or better yet call it), > that is the precedent for tunnels. I've made geneve_change_mtu follow ip_tunnel_change_mtu in v2. If it were to call it instead, are you suggesting just passing in t_hlen? Or restructuring geneve.c to re-use the whole ip_tunnel infrastructure? Also, I'm not sure where the 0xFFF8 comes from in __ip_tunnel_change_mtu. Any ideas why 0xFFF8 rather than 0xffff? It goes all the way back to the inital import of the kernel into git. David