From: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
To: "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Cc: "toke@redhat.com" <toke@redhat.com>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
"bjorn@kernel.org" <bjorn@kernel.org>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"Creeley, Brett" <brett.creeley@intel.com>,
"joamaki@gmail.com" <joamaki@gmail.com>
Subject: Re: [PATCH v5 intel-next 0/9] XDP_TX improvements for ice
Date: Tue, 17 Aug 2021 20:59:01 +0000 [thread overview]
Message-ID: <86e7bcc04d8211fe5796bd7ecbea9458a725ad03.camel@intel.com> (raw)
In-Reply-To: <20210814140812.46632-1-maciej.fijalkowski@intel.com>
On Sat, 2021-08-14 at 16:08 +0200, Maciej Fijalkowski wrote:
> With the v5, I think it's time for a proper change log.
This isn't applying to the Intel-wired-LAN tree. If you want it to go
through there, could you base the patches on that tree?
Also, looking at NIPA, it looks like patches 2 and 3 have kdoc issues.
Thanks,
Tony
> v4->v5:
> * fix issues pointed by lkp; variables used for updating ring stats
> could be un-inited
> * s/ice_ring/ice_rx_ring; it looks now symmetric given that we have
> ice_tx_ring struct dedicated for Tx ring
> * go through the code and use ice_for_each_* macros; it was spotted
> by
> Brett that there was a place around that code that this set is
> touching that was not using the ice_for_each_txq. Turned out that
> there
> were more such places
> * take care of coalesce related code; carry the info about type of
> ring
> container in ice_ring_container
> * pull out getting rid of @ring_active onto separate patch, as
> suggested
> by Brett
>
> v3->v4:
> * fix lkp issues;
>
> v2->v3:
> * improve XDP_TX in a proper way
> * split ice_ring
> * propagate XDP ring pointer to Rx ring
>
> v1->v2:
> * try to improve XDP_TX processing
>
> v4 :
> https://lore.kernel.org/bpf/20210806095539.34423-1-maciej.fijalkowski@intel.com/
> v3 :
> https://lore.kernel.org/bpf/20210805230046.28715-1-maciej.fijalkowski@intel.com/
> v2 :
> https://lore.kernel.org/bpf/20210705164338.58313-1-maciej.fijalkowski@intel.com/
> v1 :
> https://lore.kernel.org/bpf/20210601113236.42651-1-maciej.fijalkowski@intel.com/
>
> Thanks!
> Maciej
>
> Maciej Fijalkowski (9):
> ice: remove ring_active from ice_ring
> ice: move ice_container_type onto ice_ring_container
> ice: split ice_ring onto Tx/Rx separate structs
> ice: unify xdp_rings accesses
> ice: do not create xdp_frame on XDP_TX
> ice: propagate xdp_ring onto rx_ring
> ice: optimize XDP_TX workloads
> ice: introduce XDP_TX fallback path
> ice: make use of ice_for_each_* macros
>
> drivers/net/ethernet/intel/ice/ice.h | 41 +++-
> drivers/net/ethernet/intel/ice/ice_arfs.c | 2 +-
> drivers/net/ethernet/intel/ice/ice_base.c | 51 ++---
> drivers/net/ethernet/intel/ice/ice_base.h | 8 +-
> drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 9 +-
> drivers/net/ethernet/intel/ice/ice_dcb_lib.h | 10 +-
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 93 +++++----
> drivers/net/ethernet/intel/ice/ice_lib.c | 88 +++++----
> drivers/net/ethernet/intel/ice/ice_lib.h | 6 +-
> drivers/net/ethernet/intel/ice/ice_main.c | 142 +++++++++-----
> drivers/net/ethernet/intel/ice/ice_ptp.c | 2 +-
> drivers/net/ethernet/intel/ice/ice_ptp.h | 4 +-
> drivers/net/ethernet/intel/ice/ice_trace.h | 28 +--
> drivers/net/ethernet/intel/ice/ice_txrx.c | 183 +++++++++++-----
> --
> drivers/net/ethernet/intel/ice/ice_txrx.h | 126 +++++++-----
> drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 98 ++++++++--
> drivers/net/ethernet/intel/ice/ice_txrx_lib.h | 14 +-
> .../net/ethernet/intel/ice/ice_virtchnl_pf.c | 2 +-
> drivers/net/ethernet/intel/ice/ice_xsk.c | 70 ++++---
> drivers/net/ethernet/intel/ice/ice_xsk.h | 20 +-
> 20 files changed, 607 insertions(+), 390 deletions(-)
>
next prev parent reply other threads:[~2021-08-17 20:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 14:08 [PATCH v5 intel-next 0/9] XDP_TX improvements for ice Maciej Fijalkowski
2021-08-14 14:08 ` [PATCH v5 intel-next 1/9] ice: remove ring_active from ice_ring Maciej Fijalkowski
2021-08-14 14:08 ` [PATCH v5 intel-next 2/9] ice: move ice_container_type onto ice_ring_container Maciej Fijalkowski
2021-08-16 16:51 ` Creeley, Brett
2021-08-16 18:39 ` Maciej Fijalkowski
2021-08-14 14:08 ` [PATCH v5 intel-next 3/9] ice: split ice_ring onto Tx/Rx separate structs Maciej Fijalkowski
2021-08-14 16:18 ` [Intel-wired-lan] " kernel test robot
2021-08-14 14:08 ` [PATCH v5 intel-next 4/9] ice: unify xdp_rings accesses Maciej Fijalkowski
2021-08-14 14:08 ` [PATCH v5 intel-next 5/9] ice: do not create xdp_frame on XDP_TX Maciej Fijalkowski
2021-08-14 14:08 ` [PATCH v5 intel-next 6/9] ice: propagate xdp_ring onto rx_ring Maciej Fijalkowski
2021-08-14 14:08 ` [PATCH v5 intel-next 7/9] ice: optimize XDP_TX workloads Maciej Fijalkowski
2021-08-14 14:08 ` [PATCH v5 intel-next 8/9] ice: introduce XDP_TX fallback path Maciej Fijalkowski
2021-08-14 14:08 ` [PATCH v5 intel-next 9/9] ice: make use of ice_for_each_* macros Maciej Fijalkowski
2021-08-17 20:59 ` Nguyen, Anthony L [this message]
2021-08-18 7:52 ` [PATCH v5 intel-next 0/9] XDP_TX improvements for ice Maciej Fijalkowski
2021-08-18 14:03 ` Maciej Fijalkowski
2021-08-18 16:12 ` Nguyen, Anthony L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86e7bcc04d8211fe5796bd7ecbea9458a725ad03.camel@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brett.creeley@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=joamaki@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).