netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH iproute2 net-next] iproute: Display offload indication per-nexthop
@ 2017-08-03  6:13 Ido Schimmel
  2017-08-03 14:26 ` David Ahern
  2017-08-03 16:16 ` Stephen Hemminger
  0 siblings, 2 replies; 3+ messages in thread
From: Ido Schimmel @ 2017-08-03  6:13 UTC (permalink / raw)
  To: netdev; +Cc: stephen, jiri, dsahern, mlxsw, Ido Schimmel

Since kernel commit 475abbf1ef67 ("ipv4: fib: Set offload indication
according to nexthop flags") offload indication is reported on a
per-nexthop basis.

Adjust iproute2 to display it.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
---
 ip/iproute.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ip/iproute.c b/ip/iproute.c
index cb695ad..39af38c 100644
--- a/ip/iproute.c
+++ b/ip/iproute.c
@@ -696,6 +696,8 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
 				fprintf(fp, "onlink ");
 			if (nh->rtnh_flags & RTNH_F_PERVASIVE)
 				fprintf(fp, "pervasive ");
+			if (nh->rtnh_flags & RTNH_F_OFFLOAD)
+				fprintf(fp, "offload ");
 			if (nh->rtnh_flags & RTNH_F_LINKDOWN)
 				fprintf(fp, "linkdown ");
 			len -= NLMSG_ALIGN(nh->rtnh_len);
-- 
2.9.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH iproute2 net-next] iproute: Display offload indication per-nexthop
  2017-08-03  6:13 [PATCH iproute2 net-next] iproute: Display offload indication per-nexthop Ido Schimmel
@ 2017-08-03 14:26 ` David Ahern
  2017-08-03 16:16 ` Stephen Hemminger
  1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2017-08-03 14:26 UTC (permalink / raw)
  To: Ido Schimmel, netdev; +Cc: stephen, jiri, mlxsw

On 8/3/17 12:13 AM, Ido Schimmel wrote:
> Since kernel commit 475abbf1ef67 ("ipv4: fib: Set offload indication
> according to nexthop flags") offload indication is reported on a
> per-nexthop basis.
> 
> Adjust iproute2 to display it.
> 
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
> ---
>  ip/iproute.c | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: David Ahern <dsahern@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH iproute2 net-next] iproute: Display offload indication per-nexthop
  2017-08-03  6:13 [PATCH iproute2 net-next] iproute: Display offload indication per-nexthop Ido Schimmel
  2017-08-03 14:26 ` David Ahern
@ 2017-08-03 16:16 ` Stephen Hemminger
  1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2017-08-03 16:16 UTC (permalink / raw)
  To: Ido Schimmel; +Cc: netdev, jiri, dsahern, mlxsw

On Thu,  3 Aug 2017 09:13:55 +0300
Ido Schimmel <idosch@mellanox.com> wrote:

> Since kernel commit 475abbf1ef67 ("ipv4: fib: Set offload indication
> according to nexthop flags") offload indication is reported on a
> per-nexthop basis.
> 
> Adjust iproute2 to display it.
> 
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Reviewed-by: Jiri Pirko <jiri@mellanox.com>
> ---
>  ip/iproute.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/ip/iproute.c b/ip/iproute.c
> index cb695ad..39af38c 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -696,6 +696,8 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg)
>  				fprintf(fp, "onlink ");
>  			if (nh->rtnh_flags & RTNH_F_PERVASIVE)
>  				fprintf(fp, "pervasive ");
> +			if (nh->rtnh_flags & RTNH_F_OFFLOAD)
> +				fprintf(fp, "offload ");
>  			if (nh->rtnh_flags & RTNH_F_LINKDOWN)
>  				fprintf(fp, "linkdown ");
>  			len -= NLMSG_ALIGN(nh->rtnh_len);

Yet another set of flags that needs to be table driven..

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-08-03 16:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-03  6:13 [PATCH iproute2 net-next] iproute: Display offload indication per-nexthop Ido Schimmel
2017-08-03 14:26 ` David Ahern
2017-08-03 16:16 ` Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).