From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2119D28C869; Mon, 23 Feb 2026 16:09:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771862945; cv=none; b=tu8UD6wMo/hVdP+EMVeCNepHq2i0Qt4owF/WVtRELei9CpM4Trjqoy5BRRnX4TqeVXqYasWfoMI+TS9I4SqVPr3xhnk7KDackJi7KxEGfHioBDGvmq97nm0Z3ksFxZVvSx+Q/lNGDjiAJU4Zj0H4g0mIA57smazg3CJPuHWJQc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771862945; c=relaxed/simple; bh=U1f4VUWvlVoHVRzjSsvSj6+GTfFekKDeqZn6GrwXI0o=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=h/BOkjva8uPoNlA87lW1vnTJV0L42mPpMMwkGRvuYmqENEHrzwDUeeEEUve3dhXf4L0WulaToDpFbsNE1ihtn/MzJkZAQFdKXAJfE6nc+8JiTT94YWQFfs/0clxtyH0yZ+a81h5JoUfJDhq3pcZAnpJqZwNRaEku1tz8+NjRDxU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l9pVaPN/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l9pVaPN/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91C5AC116C6; Mon, 23 Feb 2026 16:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771862944; bh=U1f4VUWvlVoHVRzjSsvSj6+GTfFekKDeqZn6GrwXI0o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l9pVaPN/cxEh/suCVhuWE9zKuRvobiCEGJ0txgkBo9PpXkl47x3YeBE24NtYlHPBp Z9MvnO0WtjK2zPWfQ/IfIVLCZffKJlqemIihS/QeSLhwIJq8IdOPIU+1f9688A4XMp gwlAn+/8UAVE4a0QW6Jp5dz96715FKWMWVIWgA0sngCXHv+7g87EwavNZvdprMhmg7 MahbRAl/A4ygOiEtD77hedrDSCJEvgQIk8RNwhzzo9fFOFuUA/+QEBobC2lco7cD/+ etfl/NJ7Xp0yiJtecEPjRZB5hFueUHK0rlemZus13jXbfPV+sMsHDxL+4n4NsgZMVR B+47pl7GCN5cg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vuYUX-0000000D3Lu-3QOf; Mon, 23 Feb 2026 16:09:01 +0000 Date: Mon, 23 Feb 2026 16:09:01 +0000 Message-ID: <86jyw3a1cy.wl-maz@kernel.org> From: Marc Zyngier To: David Lechner Cc: Frederic Weisbecker , LKML , Michal =?UTF-8?B?S291dG7DvQ==?= , Andrew Morton , Bjorn Helgaas , Catalin Marinas , Chen Ridong , Danilo Krummrich , "David S . Miller" , Eric Dumazet , Gabriele Monaco , Greg Kroah-Hartman , Ingo Molnar , Jakub Kicinski , Jens Axboe , Johannes Weiner , Lai Jiangshan , Marco Crivellari , Michal Hocko , Muchun Song , Paolo Abeni , Peter Zijlstra , Phil Auld , "Rafael J . Wysocki" , Roman Gushchin , Shakeel Butt , Simon Horman , Tejun Heo , Thomas Gleixner , Vlastimil Babka , Waiman Long , Will Deacon , cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 04/33] mm: vmstat: Prepare to protect against concurrent isolated cpuset change In-Reply-To: <47be2ff3-c25a-4aab-89fc-53921af8b0a9@baylibre.com> References: <20260101221359.22298-1-frederic@kernel.org> <20260101221359.22298-5-frederic@kernel.org> <47be2ff3-c25a-4aab-89fc-53921af8b0a9@baylibre.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dlechner@baylibre.com, frederic@kernel.org, linux-kernel@vger.kernel.org, mkoutny@suse.com, akpm@linux-foundation.org, bhelgaas@google.com, catalin.marinas@arm.com, chenridong@huawei.com, dakr@kernel.org, davem@davemloft.net, edumazet@google.com, gmonaco@redhat.com, gregkh@linuxfoundation.org, mingo@redhat.com, kuba@kernel.org, axboe@kernel.dk, hannes@cmpxchg.org, jiangshanlai@gmail.com, marco.crivellari@suse.com, mhocko@suse.com, muchun.song@linux.dev, pabeni@redhat.com, peterz@infradead.org, pauld@redhat.com, rafael@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, horms@kernel.org, tj@kernel.org, tglx@linutronix.de, vbabka@suse.cz, longman@redhat.com, will@kernel.org, cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, netdev@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 23 Feb 2026 16:01:03 +0000, David Lechner wrote: > > On 1/1/26 4:13 PM, Frederic Weisbecker wrote: > > The HK_TYPE_DOMAIN housekeeping cpumask will soon be made modifiable at > > runtime. In order to synchronize against vmstat workqueue to make sure > > that no asynchronous vmstat work is pending or executing on a newly made > > isolated CPU, target and queue a vmstat work under the same RCU read > > side critical section. > > > > Whenever housekeeping will update the HK_TYPE_DOMAIN cpumask, a vmstat > > workqueue flush will also be issued in a further change to make sure > > that no work remains pending after a CPU has been made isolated. > > > > Signed-off-by: Frederic Weisbecker > > --- > > mm/vmstat.c | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/mm/vmstat.c b/mm/vmstat.c > > index 65de88cdf40e..ed19c0d42de6 100644 > > --- a/mm/vmstat.c > > +++ b/mm/vmstat.c > > @@ -2144,11 +2144,13 @@ static void vmstat_shepherd(struct work_struct *w) > > * infrastructure ever noticing. Skip regular flushing from vmstat_shepherd > > * for all isolated CPUs to avoid interference with the isolated workload. > > */ > > - if (cpu_is_isolated(cpu)) > > - continue; > > + scoped_guard(rcu) { > > + if (cpu_is_isolated(cpu)) > > + continue; > > I think this might have introduced a bug - or at least an > unintentional change in the program flow. > > scoped_guard() is implemented using a for loop. Now this continue > statement will only exit the scoped_guard() scope rather than > continuing the outer for loop. This means that cond_resched() will > be called when it previously was not. Yup, I've been bitten by that once before. It lead to very subtle breakage that took me a while to figure out. I've now mentally banished the use of scoped_guard() inside any form of loop, but that's a pretty brittle strategy... M. -- Without deviation from the norm, progress is not possible.