From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B08AC433EF for ; Thu, 2 Jun 2022 12:08:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234435AbiFBMIt (ORCPT ); Thu, 2 Jun 2022 08:08:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231604AbiFBMIs (ORCPT ); Thu, 2 Jun 2022 08:08:48 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 110BA2717BD; Thu, 2 Jun 2022 05:08:47 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id g25so4987944ljm.2; Thu, 02 Jun 2022 05:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=QdNf1+ADCDYIFdMt/u0EWuhJR3TaXSiM6WxoeP7Eubo=; b=Sr4MSscJ3lDmLRDowY0p2F36myUdh5acadCAYqP6y6lRile9Ir7mBytU3OgIgUFZUF 1CZmrb7YxF0A/b4XWk+rLAlmOMiQjL46TOhhS7qsB53sWCKLsbpKldE6N0S+YBplVoLB sBFlPQHIBjuSbG9EpX2gv1OPch3Sk2FPoFD83yjh3A0AQcFC+VJSX/x8knhDDr8Slx3u fNNpeIEbuIkrcndC7Dvct4MzKA2XSMmQWZ8MfgMcux/h4yPji5DwAZzb0jiCg572EYsm XrKx+EfbQEcGjMEUs/Rmc8WtDaD0J5+3bRqRVXOgWRlbpgBWbh6Kwc1zXesWIptqZbP+ VjbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=QdNf1+ADCDYIFdMt/u0EWuhJR3TaXSiM6WxoeP7Eubo=; b=07VkBYE3d7HkLTJwZUqeztmH3e8S6xv6Usj6UIWp+HKIFN6unOxnwqcBpsTdykIRCm 8+1nzkMBwPv+sxbwXjPuoVKnMwIhKOqtqiP7c4owwqo49kMb4SYDZ81FHvmgjnZwbgzr yZrLJMrMG7vn9iOKCD23zb28L9UsUAKyi18X1Ml6z87GPjaPCOPdYT4Js9YI/vS6daQU wRlQLRUg1f/Ls7Ie5fcTKqcoa7r7/OMzluakmCo7o95Xwnfk0/mM3i5TfpBUCzJVs6Aq Z+bkfwxSpLs9QBda2C8A4/jAdk09KoIGj4Q3In//mwGuBZMT1blD/SKNsCGxU+uiPWgN AVUA== X-Gm-Message-State: AOAM533y6nC6xd1F2m0dMKczFleJo5Tdf1b1EciYOs63HBvuD7B2fJYm qn6219szFS2s9brFtLGM7dVUEUnm4b7JLA== X-Google-Smtp-Source: ABdhPJyzjXZmbGB25Nt6LYzK4/Lb1b18NojM2rGYKC4gJb6rhYHNS5GmPPf2ZZCqPqhuXGeoBdiM6w== X-Received: by 2002:a05:651c:1a2c:b0:253:d897:ee2f with SMTP id by44-20020a05651c1a2c00b00253d897ee2fmr39569928ljb.232.1654171725398; Thu, 02 Jun 2022 05:08:45 -0700 (PDT) Received: from wse-c0127 ([208.127.141.28]) by smtp.gmail.com with ESMTPSA id h9-20020a056512054900b00477c8127e50sm1001299lfl.122.2022.06.02.05.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jun 2022 05:08:44 -0700 (PDT) From: Hans Schultz X-Google-Original-From: Hans Schultz To: Ido Schimmel , Nikolay Aleksandrov Cc: Hans Schultz , Ido Schimmel , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Shuah Khan , Daniel Borkmann , linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH V3 net-next 1/4] net: bridge: add fdb flag to extent locked port feature In-Reply-To: References: <20220524152144.40527-2-schultz.hans+netdev@gmail.com> <86sfov2w8k.fsf@gmail.com> <86sfoqgi5e.fsf@gmail.com> <86y1yfzap3.fsf@gmail.com> <86sfonjroi.fsf@gmail.com> <3d93d46d-c484-da0a-c12c-80e83eba31c9@blackwall.org> Date: Thu, 02 Jun 2022 14:08:41 +0200 Message-ID: <86mtevjmie.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > I think Hans is testing with mv88e6xxx which dumps entries directly from > HW via ndo_fdb_dump(). See dsa_slave_port_fdb_do_dump() which sets > NTF_SELF. > > Hans, are you seeing the entry twice? Once with 'master' and once with > 'self'? > When replacing a locked entry it looks like this: # bridge fdb show dev eth6 | grep 4c 00:4c:4c:4c:4c:4c vlan 1 master br0 extern_learn offload locked # bridge fdb replace 00:4c:4c:4c:4c:4c dev eth6 vlan 1 master static ; bridge fdb show dev eth6 | grep 4c 00:4c:4c:4c:4c:4c vlan 1 self static The problem is then that the function br_fdb_find_rcu(br,eth_hdr(skb)->h_source, vid); , where the h_source and vid is the entry above, does not find the entry. My hypothesis was then that this is because of the 'self' flag that I see. I am thinking that the function dsa_slave_port_fdb_do_dump() is only for debug, and thus does not really set any flags in the bridge modules FDB, but then I don't understand why the above find function does not find the entry?