Re: [Intel-wired-lan] [PATCH iwl-next] ice: add E835 device IDs

[Dawid Osuchowski <dawid.osuchowski@linux.intel.com>]

On 2025-05-16 7:30 PM, Tony Nguyen wrote:
> On 5/14/2025 3:46 AM, Dawid Osuchowski wrote:
>> diff --git a/drivers/net/ethernet/intel/ice/ice_devids.h b/drivers/ 
>> net/ethernet/intel/ice/ice_devids.h
>> index 34fd604132f5..7761c3501174 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_devids.h
>> +++ b/drivers/net/ethernet/intel/ice/ice_devids.h
>> @@ -36,6 +36,24 @@
>>   #define ICE_DEV_ID_E830_XXV_QSFP    0x12DD
>>   /* Intel(R) Ethernet Controller E830-XXV for SFP */
>>   #define ICE_DEV_ID_E830_XXV_SFP        0x12DE
>> +/* Intel(R) Ethernet Controller E835-CC for backplane */
>> +#define ICE_DEV_ID_E835CC_BACKPLANE    0x1248
>> +/* Intel(R) Ethernet Controller E835-CC for QSFP */
>> +#define ICE_DEV_ID_E835CC_QSFP56    0x1249
>> +/* Intel(R) Ethernet Controller E835-CC for SFP */
>> +#define ICE_DEV_ID_E835CC_SFP        0x124A
>> +/* Intel(R) Ethernet Controller E835-C for backplane */
>> +#define ICE_DEV_ID_E835C_BACKPLANE    0x1261
>> +/* Intel(R) Ethernet Controller E835-C for QSFP */
>> +#define ICE_DEV_ID_E835C_QSFP        0x1262
>> +/* Intel(R) Ethernet Controller E835-C for SFP */
>> +#define ICE_DEV_ID_E835C_SFP        0x1263
>> +/* Intel(R) Ethernet Controller E835-L for backplane */
>> +#define ICE_DEV_ID_E835_L_BACKPLANE    0x1265
>> +/* Intel(R) Ethernet Controller E835-L for QSFP */
>> +#define ICE_DEV_ID_E835_L_QSFP        0x1266
>> +/* Intel(R) Ethernet Controller E835-L for SFP */
>> +#define ICE_DEV_ID_E835_L_SFP        0x1267
>>   /* Intel(R) Ethernet Controller E810-C for backplane */
>>   #define ICE_DEV_ID_E810C_BACKPLANE    0x1591
> 
> For the most part this file is sorted by device id, could you move these 
> to the corresponding spot?

Sure, will send v2.

Best regards,
Dawid

> 
> Thanks,
> Tony