* [PATCH iwl-next] ice: add E835 device IDs
@ 2025-05-14 10:46 Dawid Osuchowski
2025-05-15 20:02 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Dawid Osuchowski @ 2025-05-14 10:46 UTC (permalink / raw)
To: intel-wired-lan; +Cc: netdev, Dawid Osuchowski, Konrad Knitter
E835 is an enhanced version of the E830.
It continues to use the same set of commands, registers and interfaces
as other devices in the 800 Series.
Following device IDs are added:
- 0x1248: Intel(R) Ethernet Controller E835-CC for backplane
- 0x1249: Intel(R) Ethernet Controller E835-CC for QSFP
- 0x124A: Intel(R) Ethernet Controller E835-CC for SFP
- 0x1261: Intel(R) Ethernet Controller E835-C for backplane
- 0x1262: Intel(R) Ethernet Controller E835-C for QSFP
- 0x1263: Intel(R) Ethernet Controller E835-C for SFP
- 0x1265: Intel(R) Ethernet Controller E835-L for backplane
- 0x1266: Intel(R) Ethernet Controller E835-L for QSFP
- 0x1267: Intel(R) Ethernet Controller E835-L for SFP
Reviewed-by: Konrad Knitter <konrad.knitter@intel.com>
Signed-off-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
---
drivers/net/ethernet/intel/ice/ice_common.c | 9 +++++++++
drivers/net/ethernet/intel/ice/ice_devids.h | 18 ++++++++++++++++++
drivers/net/ethernet/intel/ice/ice_main.c | 9 +++++++++
3 files changed, 36 insertions(+)
diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
index 6e38d46c2c51..010ad09b3200 100644
--- a/drivers/net/ethernet/intel/ice/ice_common.c
+++ b/drivers/net/ethernet/intel/ice/ice_common.c
@@ -171,6 +171,15 @@ static int ice_set_mac_type(struct ice_hw *hw)
case ICE_DEV_ID_E830_XXV_QSFP:
case ICE_DEV_ID_E830C_SFP:
case ICE_DEV_ID_E830_XXV_SFP:
+ case ICE_DEV_ID_E835CC_BACKPLANE:
+ case ICE_DEV_ID_E835CC_QSFP56:
+ case ICE_DEV_ID_E835CC_SFP:
+ case ICE_DEV_ID_E835C_BACKPLANE:
+ case ICE_DEV_ID_E835C_QSFP:
+ case ICE_DEV_ID_E835C_SFP:
+ case ICE_DEV_ID_E835_L_BACKPLANE:
+ case ICE_DEV_ID_E835_L_QSFP:
+ case ICE_DEV_ID_E835_L_SFP:
hw->mac_type = ICE_MAC_E830;
break;
default:
diff --git a/drivers/net/ethernet/intel/ice/ice_devids.h b/drivers/net/ethernet/intel/ice/ice_devids.h
index 34fd604132f5..7761c3501174 100644
--- a/drivers/net/ethernet/intel/ice/ice_devids.h
+++ b/drivers/net/ethernet/intel/ice/ice_devids.h
@@ -36,6 +36,24 @@
#define ICE_DEV_ID_E830_XXV_QSFP 0x12DD
/* Intel(R) Ethernet Controller E830-XXV for SFP */
#define ICE_DEV_ID_E830_XXV_SFP 0x12DE
+/* Intel(R) Ethernet Controller E835-CC for backplane */
+#define ICE_DEV_ID_E835CC_BACKPLANE 0x1248
+/* Intel(R) Ethernet Controller E835-CC for QSFP */
+#define ICE_DEV_ID_E835CC_QSFP56 0x1249
+/* Intel(R) Ethernet Controller E835-CC for SFP */
+#define ICE_DEV_ID_E835CC_SFP 0x124A
+/* Intel(R) Ethernet Controller E835-C for backplane */
+#define ICE_DEV_ID_E835C_BACKPLANE 0x1261
+/* Intel(R) Ethernet Controller E835-C for QSFP */
+#define ICE_DEV_ID_E835C_QSFP 0x1262
+/* Intel(R) Ethernet Controller E835-C for SFP */
+#define ICE_DEV_ID_E835C_SFP 0x1263
+/* Intel(R) Ethernet Controller E835-L for backplane */
+#define ICE_DEV_ID_E835_L_BACKPLANE 0x1265
+/* Intel(R) Ethernet Controller E835-L for QSFP */
+#define ICE_DEV_ID_E835_L_QSFP 0x1266
+/* Intel(R) Ethernet Controller E835-L for SFP */
+#define ICE_DEV_ID_E835_L_SFP 0x1267
/* Intel(R) Ethernet Controller E810-C for backplane */
#define ICE_DEV_ID_E810C_BACKPLANE 0x1591
/* Intel(R) Ethernet Controller E810-C for QSFP */
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index c4264984cfcb..5c941f4426d1 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -5906,6 +5906,15 @@ static const struct pci_device_id ice_pci_tbl[] = {
{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E830_XXV_QSFP), },
{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E830C_SFP), },
{ PCI_VDEVICE(INTEL, ICE_DEV_ID_E830_XXV_SFP), },
+ { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835CC_BACKPLANE), },
+ { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835CC_QSFP56), },
+ { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835CC_SFP), },
+ { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835C_BACKPLANE), },
+ { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835C_QSFP), },
+ { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835C_SFP), },
+ { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835_L_BACKPLANE), },
+ { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835_L_QSFP), },
+ { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835_L_SFP), },
/* required last entry */
{}
};
--
2.47.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH iwl-next] ice: add E835 device IDs
2025-05-14 10:46 [PATCH iwl-next] ice: add E835 device IDs Dawid Osuchowski
@ 2025-05-15 20:02 ` Simon Horman
2025-05-16 17:30 ` [Intel-wired-lan] " Tony Nguyen
2025-05-16 20:57 ` Paul Menzel
2 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2025-05-15 20:02 UTC (permalink / raw)
To: Dawid Osuchowski; +Cc: intel-wired-lan, netdev, Konrad Knitter
On Wed, May 14, 2025 at 12:46:32PM +0200, Dawid Osuchowski wrote:
> E835 is an enhanced version of the E830.
> It continues to use the same set of commands, registers and interfaces
> as other devices in the 800 Series.
>
> Following device IDs are added:
> - 0x1248: Intel(R) Ethernet Controller E835-CC for backplane
> - 0x1249: Intel(R) Ethernet Controller E835-CC for QSFP
> - 0x124A: Intel(R) Ethernet Controller E835-CC for SFP
> - 0x1261: Intel(R) Ethernet Controller E835-C for backplane
> - 0x1262: Intel(R) Ethernet Controller E835-C for QSFP
> - 0x1263: Intel(R) Ethernet Controller E835-C for SFP
> - 0x1265: Intel(R) Ethernet Controller E835-L for backplane
> - 0x1266: Intel(R) Ethernet Controller E835-L for QSFP
> - 0x1267: Intel(R) Ethernet Controller E835-L for SFP
>
> Reviewed-by: Konrad Knitter <konrad.knitter@intel.com>
> Signed-off-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next] ice: add E835 device IDs
2025-05-14 10:46 [PATCH iwl-next] ice: add E835 device IDs Dawid Osuchowski
2025-05-15 20:02 ` Simon Horman
@ 2025-05-16 17:30 ` Tony Nguyen
2025-05-19 11:08 ` Dawid Osuchowski
2025-05-16 20:57 ` Paul Menzel
2 siblings, 1 reply; 8+ messages in thread
From: Tony Nguyen @ 2025-05-16 17:30 UTC (permalink / raw)
To: Dawid Osuchowski, intel-wired-lan; +Cc: netdev, Konrad Knitter
On 5/14/2025 3:46 AM, Dawid Osuchowski wrote:
> E835 is an enhanced version of the E830.
> It continues to use the same set of commands, registers and interfaces
> as other devices in the 800 Series.
>
> Following device IDs are added:
> - 0x1248: Intel(R) Ethernet Controller E835-CC for backplane
> - 0x1249: Intel(R) Ethernet Controller E835-CC for QSFP
> - 0x124A: Intel(R) Ethernet Controller E835-CC for SFP
> - 0x1261: Intel(R) Ethernet Controller E835-C for backplane
> - 0x1262: Intel(R) Ethernet Controller E835-C for QSFP
> - 0x1263: Intel(R) Ethernet Controller E835-C for SFP
> - 0x1265: Intel(R) Ethernet Controller E835-L for backplane
> - 0x1266: Intel(R) Ethernet Controller E835-L for QSFP
> - 0x1267: Intel(R) Ethernet Controller E835-L for SFP
>
> Reviewed-by: Konrad Knitter <konrad.knitter@intel.com>
> Signed-off-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
> ---
...
> diff --git a/drivers/net/ethernet/intel/ice/ice_devids.h b/drivers/net/ethernet/intel/ice/ice_devids.h
> index 34fd604132f5..7761c3501174 100644
> --- a/drivers/net/ethernet/intel/ice/ice_devids.h
> +++ b/drivers/net/ethernet/intel/ice/ice_devids.h
> @@ -36,6 +36,24 @@
> #define ICE_DEV_ID_E830_XXV_QSFP 0x12DD
> /* Intel(R) Ethernet Controller E830-XXV for SFP */
> #define ICE_DEV_ID_E830_XXV_SFP 0x12DE
> +/* Intel(R) Ethernet Controller E835-CC for backplane */
> +#define ICE_DEV_ID_E835CC_BACKPLANE 0x1248
> +/* Intel(R) Ethernet Controller E835-CC for QSFP */
> +#define ICE_DEV_ID_E835CC_QSFP56 0x1249
> +/* Intel(R) Ethernet Controller E835-CC for SFP */
> +#define ICE_DEV_ID_E835CC_SFP 0x124A
> +/* Intel(R) Ethernet Controller E835-C for backplane */
> +#define ICE_DEV_ID_E835C_BACKPLANE 0x1261
> +/* Intel(R) Ethernet Controller E835-C for QSFP */
> +#define ICE_DEV_ID_E835C_QSFP 0x1262
> +/* Intel(R) Ethernet Controller E835-C for SFP */
> +#define ICE_DEV_ID_E835C_SFP 0x1263
> +/* Intel(R) Ethernet Controller E835-L for backplane */
> +#define ICE_DEV_ID_E835_L_BACKPLANE 0x1265
> +/* Intel(R) Ethernet Controller E835-L for QSFP */
> +#define ICE_DEV_ID_E835_L_QSFP 0x1266
> +/* Intel(R) Ethernet Controller E835-L for SFP */
> +#define ICE_DEV_ID_E835_L_SFP 0x1267
> /* Intel(R) Ethernet Controller E810-C for backplane */
> #define ICE_DEV_ID_E810C_BACKPLANE 0x1591
For the most part this file is sorted by device id, could you move these
to the corresponding spot?
Thanks,
Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next] ice: add E835 device IDs
2025-05-16 17:30 ` [Intel-wired-lan] " Tony Nguyen
@ 2025-05-19 11:08 ` Dawid Osuchowski
0 siblings, 0 replies; 8+ messages in thread
From: Dawid Osuchowski @ 2025-05-19 11:08 UTC (permalink / raw)
To: Tony Nguyen, intel-wired-lan; +Cc: netdev, Konrad Knitter
On 2025-05-16 7:30 PM, Tony Nguyen wrote:
> On 5/14/2025 3:46 AM, Dawid Osuchowski wrote:
>> diff --git a/drivers/net/ethernet/intel/ice/ice_devids.h b/drivers/
>> net/ethernet/intel/ice/ice_devids.h
>> index 34fd604132f5..7761c3501174 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_devids.h
>> +++ b/drivers/net/ethernet/intel/ice/ice_devids.h
>> @@ -36,6 +36,24 @@
>> #define ICE_DEV_ID_E830_XXV_QSFP 0x12DD
>> /* Intel(R) Ethernet Controller E830-XXV for SFP */
>> #define ICE_DEV_ID_E830_XXV_SFP 0x12DE
>> +/* Intel(R) Ethernet Controller E835-CC for backplane */
>> +#define ICE_DEV_ID_E835CC_BACKPLANE 0x1248
>> +/* Intel(R) Ethernet Controller E835-CC for QSFP */
>> +#define ICE_DEV_ID_E835CC_QSFP56 0x1249
>> +/* Intel(R) Ethernet Controller E835-CC for SFP */
>> +#define ICE_DEV_ID_E835CC_SFP 0x124A
>> +/* Intel(R) Ethernet Controller E835-C for backplane */
>> +#define ICE_DEV_ID_E835C_BACKPLANE 0x1261
>> +/* Intel(R) Ethernet Controller E835-C for QSFP */
>> +#define ICE_DEV_ID_E835C_QSFP 0x1262
>> +/* Intel(R) Ethernet Controller E835-C for SFP */
>> +#define ICE_DEV_ID_E835C_SFP 0x1263
>> +/* Intel(R) Ethernet Controller E835-L for backplane */
>> +#define ICE_DEV_ID_E835_L_BACKPLANE 0x1265
>> +/* Intel(R) Ethernet Controller E835-L for QSFP */
>> +#define ICE_DEV_ID_E835_L_QSFP 0x1266
>> +/* Intel(R) Ethernet Controller E835-L for SFP */
>> +#define ICE_DEV_ID_E835_L_SFP 0x1267
>> /* Intel(R) Ethernet Controller E810-C for backplane */
>> #define ICE_DEV_ID_E810C_BACKPLANE 0x1591
>
> For the most part this file is sorted by device id, could you move these
> to the corresponding spot?
Sure, will send v2.
Best regards,
Dawid
>
> Thanks,
> Tony
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next] ice: add E835 device IDs
2025-05-14 10:46 [PATCH iwl-next] ice: add E835 device IDs Dawid Osuchowski
2025-05-15 20:02 ` Simon Horman
2025-05-16 17:30 ` [Intel-wired-lan] " Tony Nguyen
@ 2025-05-16 20:57 ` Paul Menzel
2025-05-19 11:11 ` Dawid Osuchowski
2 siblings, 1 reply; 8+ messages in thread
From: Paul Menzel @ 2025-05-16 20:57 UTC (permalink / raw)
To: Dawid Osuchowski; +Cc: intel-wired-lan, netdev, Konrad Knitter
Dear Dawid,
Thank you for your patch.
Am 14.05.25 um 12:46 schrieb Dawid Osuchowski:
> E835 is an enhanced version of the E830.
> It continues to use the same set of commands, registers and interfaces
> as other devices in the 800 Series.
>
> Following device IDs are added:
> - 0x1248: Intel(R) Ethernet Controller E835-CC for backplane
> - 0x1249: Intel(R) Ethernet Controller E835-CC for QSFP
> - 0x124A: Intel(R) Ethernet Controller E835-CC for SFP
> - 0x1261: Intel(R) Ethernet Controller E835-C for backplane
> - 0x1262: Intel(R) Ethernet Controller E835-C for QSFP
> - 0x1263: Intel(R) Ethernet Controller E835-C for SFP
> - 0x1265: Intel(R) Ethernet Controller E835-L for backplane
> - 0x1266: Intel(R) Ethernet Controller E835-L for QSFP
> - 0x1267: Intel(R) Ethernet Controller E835-L for SFP
Should you resend, it’d be great, if you added the datasheet name, where
these id’s are present.
> Reviewed-by: Konrad Knitter <konrad.knitter@intel.com>
> Signed-off-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_common.c | 9 +++++++++
> drivers/net/ethernet/intel/ice/ice_devids.h | 18 ++++++++++++++++++
> drivers/net/ethernet/intel/ice/ice_main.c | 9 +++++++++
> 3 files changed, 36 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
> index 6e38d46c2c51..010ad09b3200 100644
> --- a/drivers/net/ethernet/intel/ice/ice_common.c
> +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> @@ -171,6 +171,15 @@ static int ice_set_mac_type(struct ice_hw *hw)
> case ICE_DEV_ID_E830_XXV_QSFP:
> case ICE_DEV_ID_E830C_SFP:
> case ICE_DEV_ID_E830_XXV_SFP:
> + case ICE_DEV_ID_E835CC_BACKPLANE:
> + case ICE_DEV_ID_E835CC_QSFP56:
> + case ICE_DEV_ID_E835CC_SFP:
> + case ICE_DEV_ID_E835C_BACKPLANE:
> + case ICE_DEV_ID_E835C_QSFP:
> + case ICE_DEV_ID_E835C_SFP:
> + case ICE_DEV_ID_E835_L_BACKPLANE:
> + case ICE_DEV_ID_E835_L_QSFP:
> + case ICE_DEV_ID_E835_L_SFP:
> hw->mac_type = ICE_MAC_E830;
> break;
> default:
> diff --git a/drivers/net/ethernet/intel/ice/ice_devids.h b/drivers/net/ethernet/intel/ice/ice_devids.h
> index 34fd604132f5..7761c3501174 100644
> --- a/drivers/net/ethernet/intel/ice/ice_devids.h
> +++ b/drivers/net/ethernet/intel/ice/ice_devids.h
> @@ -36,6 +36,24 @@
> #define ICE_DEV_ID_E830_XXV_QSFP 0x12DD
> /* Intel(R) Ethernet Controller E830-XXV for SFP */
> #define ICE_DEV_ID_E830_XXV_SFP 0x12DE
> +/* Intel(R) Ethernet Controller E835-CC for backplane */
> +#define ICE_DEV_ID_E835CC_BACKPLANE 0x1248
> +/* Intel(R) Ethernet Controller E835-CC for QSFP */
> +#define ICE_DEV_ID_E835CC_QSFP56 0x1249
> +/* Intel(R) Ethernet Controller E835-CC for SFP */
> +#define ICE_DEV_ID_E835CC_SFP 0x124A
> +/* Intel(R) Ethernet Controller E835-C for backplane */
> +#define ICE_DEV_ID_E835C_BACKPLANE 0x1261
> +/* Intel(R) Ethernet Controller E835-C for QSFP */
> +#define ICE_DEV_ID_E835C_QSFP 0x1262
> +/* Intel(R) Ethernet Controller E835-C for SFP */
> +#define ICE_DEV_ID_E835C_SFP 0x1263
> +/* Intel(R) Ethernet Controller E835-L for backplane */
> +#define ICE_DEV_ID_E835_L_BACKPLANE 0x1265
> +/* Intel(R) Ethernet Controller E835-L for QSFP */
> +#define ICE_DEV_ID_E835_L_QSFP 0x1266
> +/* Intel(R) Ethernet Controller E835-L for SFP */
> +#define ICE_DEV_ID_E835_L_SFP 0x1267
> /* Intel(R) Ethernet Controller E810-C for backplane */
> #define ICE_DEV_ID_E810C_BACKPLANE 0x1591
> /* Intel(R) Ethernet Controller E810-C for QSFP */
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index c4264984cfcb..5c941f4426d1 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -5906,6 +5906,15 @@ static const struct pci_device_id ice_pci_tbl[] = {
> { PCI_VDEVICE(INTEL, ICE_DEV_ID_E830_XXV_QSFP), },
> { PCI_VDEVICE(INTEL, ICE_DEV_ID_E830C_SFP), },
> { PCI_VDEVICE(INTEL, ICE_DEV_ID_E830_XXV_SFP), },
> + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835CC_BACKPLANE), },
> + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835CC_QSFP56), },
> + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835CC_SFP), },
> + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835C_BACKPLANE), },
> + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835C_QSFP), },
> + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835C_SFP), },
> + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835_L_BACKPLANE), },
> + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835_L_QSFP), },
> + { PCI_VDEVICE(INTEL, ICE_DEV_ID_E835_L_SFP), },
> /* required last entry */
> {}
> };
Kind regards,
Paul
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-next] ice: add E835 device IDs
2025-05-16 20:57 ` Paul Menzel
@ 2025-05-19 11:11 ` Dawid Osuchowski
2025-05-22 7:01 ` Paul Menzel
0 siblings, 1 reply; 8+ messages in thread
From: Dawid Osuchowski @ 2025-05-19 11:11 UTC (permalink / raw)
To: Paul Menzel; +Cc: intel-wired-lan, netdev, Konrad Knitter
On 2025-05-16 10:57 PM, Paul Menzel wrote:
> Am 14.05.25 um 12:46 schrieb Dawid Osuchowski:
>> E835 is an enhanced version of the E830.
>> It continues to use the same set of commands, registers and interfaces
>> as other devices in the 800 Series.
>>
>> Following device IDs are added:
>> - 0x1248: Intel(R) Ethernet Controller E835-CC for backplane
>> - 0x1249: Intel(R) Ethernet Controller E835-CC for QSFP
>> - 0x124A: Intel(R) Ethernet Controller E835-CC for SFP
>> - 0x1261: Intel(R) Ethernet Controller E835-C for backplane
>> - 0x1262: Intel(R) Ethernet Controller E835-C for QSFP
>> - 0x1263: Intel(R) Ethernet Controller E835-C for SFP
>> - 0x1265: Intel(R) Ethernet Controller E835-L for backplane
>> - 0x1266: Intel(R) Ethernet Controller E835-L for QSFP
>> - 0x1267: Intel(R) Ethernet Controller E835-L for SFP
>
> Should you resend, it’d be great, if you added the datasheet name, where
> these id’s are present.
Sorry it isn't publicly available yet.
Best regards,
Dawid
> Kind regards,
>
> Paul
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next] ice: add E835 device IDs
2025-05-19 11:11 ` Dawid Osuchowski
@ 2025-05-22 7:01 ` Paul Menzel
2025-05-22 7:58 ` Dawid Osuchowski
0 siblings, 1 reply; 8+ messages in thread
From: Paul Menzel @ 2025-05-22 7:01 UTC (permalink / raw)
To: Dawid Osuchowski; +Cc: intel-wired-lan, netdev, Konrad Knitter
Dear Dawid,
Am 19.05.25 um 13:11 schrieb Dawid Osuchowski:
> On 2025-05-16 10:57 PM, Paul Menzel wrote:
>> Am 14.05.25 um 12:46 schrieb Dawid Osuchowski:
>>> E835 is an enhanced version of the E830.
>>> It continues to use the same set of commands, registers and interfaces
>>> as other devices in the 800 Series.
>>>
>>> Following device IDs are added:
>>> - 0x1248: Intel(R) Ethernet Controller E835-CC for backplane
>>> - 0x1249: Intel(R) Ethernet Controller E835-CC for QSFP
>>> - 0x124A: Intel(R) Ethernet Controller E835-CC for SFP
>>> - 0x1261: Intel(R) Ethernet Controller E835-C for backplane
>>> - 0x1262: Intel(R) Ethernet Controller E835-C for QSFP
>>> - 0x1263: Intel(R) Ethernet Controller E835-C for SFP
>>> - 0x1265: Intel(R) Ethernet Controller E835-L for backplane
>>> - 0x1266: Intel(R) Ethernet Controller E835-L for QSFP
>>> - 0x1267: Intel(R) Ethernet Controller E835-L for SFP
>>
>> Should you resend, it’d be great, if you added the datasheet name,
>> where these id’s are present.
>
> Sorry it isn't publicly available yet.
Too bad, but the name of the datasheet would still be useful in the
commit message, so people could point to it, or, should it ever be made
public, can find it.
Kind regards,
Paul
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-next] ice: add E835 device IDs
2025-05-22 7:01 ` Paul Menzel
@ 2025-05-22 7:58 ` Dawid Osuchowski
0 siblings, 0 replies; 8+ messages in thread
From: Dawid Osuchowski @ 2025-05-22 7:58 UTC (permalink / raw)
To: Paul Menzel; +Cc: intel-wired-lan, netdev, Konrad Knitter
On 2025-05-22 9:01 AM, Paul Menzel wrote:
> Dear Dawid,
>
>
> Am 19.05.25 um 13:11 schrieb Dawid Osuchowski:
>> On 2025-05-16 10:57 PM, Paul Menzel wrote:
>>> Am 14.05.25 um 12:46 schrieb Dawid Osuchowski:
>>>> E835 is an enhanced version of the E830.
>>>> It continues to use the same set of commands, registers and interfaces
>>>> as other devices in the 800 Series.
>>>>
>>>> Following device IDs are added:
>>>> - 0x1248: Intel(R) Ethernet Controller E835-CC for backplane
>>>> - 0x1249: Intel(R) Ethernet Controller E835-CC for QSFP
>>>> - 0x124A: Intel(R) Ethernet Controller E835-CC for SFP
>>>> - 0x1261: Intel(R) Ethernet Controller E835-C for backplane
>>>> - 0x1262: Intel(R) Ethernet Controller E835-C for QSFP
>>>> - 0x1263: Intel(R) Ethernet Controller E835-C for SFP
>>>> - 0x1265: Intel(R) Ethernet Controller E835-L for backplane
>>>> - 0x1266: Intel(R) Ethernet Controller E835-L for QSFP
>>>> - 0x1267: Intel(R) Ethernet Controller E835-L for SFP
>>>
>>> Should you resend, it’d be great, if you added the datasheet name,
>>> where these id’s are present.
>>
>> Sorry it isn't publicly available yet.
>
> Too bad, but the name of the datasheet would still be useful in the
> commit message, so people could point to it, or, should it ever be made
> public, can find it.
I understand your concern.
Given our datasheet naming scheme so far [1], I think folks
interested in viewing the datasheet can easily search our Resource &
Documentation Center [2] to find what they're looking for once it
becomes available.
[1]
https://www.intel.com/content/www/us/en/content-details/613875/intel-ethernet-controller-e810-datasheet.html
[2]
https://www.intel.com/content/www/us/en/resources-documentation/developer.html
Best regards,
Dawid
>
>
> Kind regards,
>
> Paul
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-05-22 7:58 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-14 10:46 [PATCH iwl-next] ice: add E835 device IDs Dawid Osuchowski
2025-05-15 20:02 ` Simon Horman
2025-05-16 17:30 ` [Intel-wired-lan] " Tony Nguyen
2025-05-19 11:08 ` Dawid Osuchowski
2025-05-16 20:57 ` Paul Menzel
2025-05-19 11:11 ` Dawid Osuchowski
2025-05-22 7:01 ` Paul Menzel
2025-05-22 7:58 ` Dawid Osuchowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).