From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH 2/3] net: phy: vitesse: Add support for VSC73xx Date: Thu, 14 Jun 2018 09:29:32 -0700 Message-ID: <87156f76-449c-1ec3-e7fa-776c2fddc992@gmail.com> References: <20180614123534.8063-1-linus.walleij@linaro.org> <20180614123534.8063-3-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, openwrt-devel@lists.openwrt.org, LEDE Development List , Gabor Juhos To: Linus Walleij , Andrew Lunn , Vivien Didelot , Woojung Huh , Microchip Linux Driver Support Return-path: Received: from mail-oi0-f67.google.com ([209.85.218.67]:40130 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755102AbeFNQ3i (ORCPT ); Thu, 14 Jun 2018 12:29:38 -0400 Received: by mail-oi0-f67.google.com with SMTP id f79-v6so6210828oib.7 for ; Thu, 14 Jun 2018 09:29:38 -0700 (PDT) In-Reply-To: <20180614123534.8063-3-linus.walleij@linaro.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 06/14/2018 05:35 AM, Linus Walleij wrote: > The VSC7385, VSC7388, VSC7395 and VSC7398 are integrated > switch/router chips for 5+1 or 8-port switches/routers. When > managed directly by Linux using DSA we need to do a special > set-up "dance" on the PHY. Unfortunately these sequences > switches the PHY to undocumented pages named 2a30 and 52b6 > and does undocumented things. It is described by these opaque > sequences also in the reference manual. This is a best > effort to integrate it anyways. > > Signed-off-by: Linus Walleij Probably as good as it can get given the information you have access to. Maybe the guys at Mircochip could help, adding them. Reviewed-by: Florian Fainelli Just one nit below: > --- > drivers/net/phy/vitesse.c | 162 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 162 insertions(+) > > diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c > index d9dd8fbfffc7..526c71ae7d96 100644 > --- a/drivers/net/phy/vitesse.c > +++ b/drivers/net/phy/vitesse.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include Is that needed? -- Florian