From: "Björn Töpel" <bjorn@kernel.org>
To: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Cc: Clement Lecigne <clecigne@google.com>,
aleksander.lobakin@intel.com, edumazet@google.com,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, kuba@kernel.org, sdf@fomichev.me,
horms@kernel.org, john.fastabend@gmail.com, ast@kernel.org,
daniel@iogearbox.net
Subject: Re: [PATCH v3] xsk: fix memory corruptions in net/core/xdp.c
Date: Sat, 17 Oct 2026 16:37:43 +0200 [thread overview]
Message-ID: <871p9o4clk.fsf@all.your.base.are.belong.to.us> (raw)
In-Reply-To: <atOBnjNbppL02n8/@boxer>
Maciej Fijalkowski <maciej.fijalkowski@intel.com> writes:
>> Or am I missing another check?
>
> I missed your trick with xdp.frags on prog side. Get this fixed then!
> :D I
...so many bugs... ;)
> had a thought like 'who cares if we overwrite struct not used in linear
> traffic' but as Clement said somewhere destructor_arg overwrite would make
> a mess.
>
> Side note is ice currently still only allows 3k buffers for linear XDP
> progs but it currently works with page_pool not with magic page split
> mechanism, so the limit should be lifted.
>
> I might take this as an AR but anyone reading this in future feel free to
> pick it up.
>
> Bjorn, let us see if Clement responses in some nearby future, otherwise
> please go forward and submit a standalone fix out of your series.
SG!
Björn
prev parent reply other threads:[~2026-10-17 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 7:22 [PATCH v3] xsk: fix memory corruptions in net/core/xdp.c Clement Lecigne
2026-06-29 10:34 ` Fijalkowski, Maciej
2026-06-29 11:15 ` Clement Lecigne
2026-07-01 14:52 ` Paolo Abeni
2026-10-16 11:19 ` Björn Töpel
2026-10-16 12:57 ` Maciej Fijalkowski
2026-10-16 20:15 ` Björn Töpel
2026-10-17 14:09 ` Maciej Fijalkowski
2026-10-17 14:37 ` Björn Töpel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871p9o4clk.fsf@all.your.base.are.belong.to.us \
--to=bjorn@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clecigne@google.com \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox