From: Petr Machata <petrm@nvidia.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: Petr Machata <petrm@nvidia.com>, David Ahern <dsahern@gmail.com>,
<netdev@vger.kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>
Subject: Re: [PATCH iproute2-next 3/4] lib: bridge: Add a module for bridge-related helpers
Date: Mon, 9 Jun 2025 16:42:53 +0200 [thread overview]
Message-ID: <871prtf028.fsf@nvidia.com> (raw)
In-Reply-To: <aEWdqycUQBuevEtZ@shredder>
Ido Schimmel <idosch@nvidia.com> writes:
> On Fri, Jun 06, 2025 at 05:04:52PM +0200, Petr Machata wrote:
>> `ip stats' displays a range of bridge_slave-related statistics, but not
>> the VLAN stats. `bridge vlan' actually has code to show these. Extract the
>> code to libutil so that it can be reused between the bridge and ip stats
>> tools.
>>
>> Rename them reasonably so as not to litter the global namespace.
>>
>> Signed-off-by: Petr Machata <petrm@nvidia.com>
>> ---
>> bridge/vlan.c | 50 +++++-------------------------------------------
>> include/bridge.h | 11 +++++++++++
>> lib/Makefile | 3 ++-
>> lib/bridge.c | 47 +++++++++++++++++++++++++++++++++++++++++++++
>> 4 files changed, 65 insertions(+), 46 deletions(-)
>> create mode 100644 include/bridge.h
>> create mode 100644 lib/bridge.c
>
> Add file entry to MAINTAINERS?
OK
next prev parent reply other threads:[~2025-06-09 14:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 15:04 [PATCH iproute2-next 0/4] ip: Support bridge VLAN stats in `ip stats' Petr Machata
2025-06-06 15:04 ` [PATCH iproute2-next 1/4] ip: ipstats: Iterate all xstats attributes Petr Machata
2025-06-08 14:23 ` Ido Schimmel
2025-06-09 14:10 ` Petr Machata
2025-06-06 15:04 ` [PATCH iproute2-next 2/4] ip: ip_common: Drop ipstats_stat_desc_xstats::inner_max Petr Machata
2025-06-08 14:24 ` Ido Schimmel
2025-06-06 15:04 ` [PATCH iproute2-next 3/4] lib: bridge: Add a module for bridge-related helpers Petr Machata
2025-06-06 15:32 ` Nikolay Aleksandrov
2025-06-09 13:39 ` Petr Machata
2025-06-08 14:26 ` Ido Schimmel
2025-06-09 14:42 ` Petr Machata [this message]
2025-06-06 15:04 ` [PATCH iproute2-next 4/4] ip: iplink_bridge: Support bridge VLAN stats in `ip stats' Petr Machata
2025-06-08 14:44 ` Ido Schimmel
2025-06-09 14:10 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871prtf028.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=dsahern@gmail.com \
--cc=idosch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).