From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A1D8C2BB41 for ; Wed, 17 Aug 2022 10:42:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231574AbiHQKmA (ORCPT ); Wed, 17 Aug 2022 06:42:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbiHQKl7 (ORCPT ); Wed, 17 Aug 2022 06:41:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C2715924A; Wed, 17 Aug 2022 03:41:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3098AB81CC7; Wed, 17 Aug 2022 10:41:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CD8CC433C1; Wed, 17 Aug 2022 10:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660732914; bh=jSwzVf5c/jELVgW/bVGmMIh+NBm1nJk4nPTUCH5zvMk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Zg9RFhuBsHJI2Q3BgJr0bMTVCwbXLiAkpq2Ndm8f6D6KyXcA55Uf0SJ1gabl6iEXQ Oa+K0Q5eNAVaJqmc1sswqwpkPGlhMULEfBgXURVZnp+KnShfJgo8GfFPCmEpuAjpJf WqGTLS/1BPyNPqEyAQQHY2Bz4PFHhMDZPLbd6Mee6ZPtNSfrrfMQARROxhXoaBdNkn 8GioXlPDA0Jh1xGV3OEPPI04Q7SRrgRiwKaTaH1IVj7mWJ5hAxemKENCcP0Ame0e2P 5LmtApRvnF4IHjPCpwjzx1KrC7Bg8J9tXfBXJ0esdyKjk/N5w0O3Nb/ZIG3tzPorbd f1wnpQgIkRSQw== From: Kalle Valo To: Alvin =?utf-8?Q?=C5=A0ipraga?= Cc: Alvin =?utf-8?Q?=C5=A0ipraga?= , Arend van Spriel , Franky Lin , Hante Meuleman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Wright Feng , Chi-hsien Lin , Ahmad Fatoum , "linux-wireless\@vger.kernel.org" , "brcm80211-dev-list.pdl\@broadcom.com" , "SHA-cyfmac-dev-list\@infineon.com" , "netdev\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [1/6] wifi: brcmfmac: fix continuous 802.1x tx pending timeout error In-Reply-To: <20220817083432.wgkhhtihtv7wdwoq@bang-olufsen.dk> ("Alvin \=\?utf-8\?Q\?\=C5\=A0ipraga\=22's\?\= message of "Wed, 17 Aug 2022 08:34:32 +0000") References: <20220722115632.620681-2-alvin@pqrs.dk> <166011047689.24475.5790257380580454361.kvalo@kernel.org> <20220817083432.wgkhhtihtv7wdwoq@bang-olufsen.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Wed, 17 Aug 2022 13:41:47 +0300 Message-ID: <871qtfm9sk.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Alvin =C5=A0ipraga writes: > Hi Kalle, > > On Wed, Aug 10, 2022 at 05:48:01AM +0000, Kalle Valo wrote: >> Alvin =C5=A0ipraga wrote: >>=20 >> > From: Wright Feng >> >=20 >> > The race condition in brcmf_msgbuf_txflow and brcmf_msgbuf_delete_flow= ring >> > makes tx_msghdr writing after brcmf_msgbuf_remove_flowring. Host >> > driver should delete flowring after txflow complete and all txstatus b= ack, >> > or pend_8021x_cnt will never be zero and cause every connection 950 >> > milliseconds(MAX_WAIT_FOR_8021X_TX) delay. >> >=20 >> > Signed-off-by: Wright Feng >> > Signed-off-by: Chi-hsien Lin >> > Signed-off-by: Ahmad Fatoum >> > Signed-off-by: Alvin =C5=A0ipraga >>=20 >> 5 patches applied to wireless-next.git, thanks. >>=20 >> 0fa24196e425 wifi: brcmfmac: fix continuous 802.1x tx pending timeout er= ror >> 09be7546a602 wifi: brcmfmac: fix scheduling while atomic issue when >> deleting flowring >> aa666b68e73f wifi: brcmfmac: fix invalid address access when enabling SC= AN log level >> 5606aeaad01e wifi: brcmfmac: Fix to add brcmf_clear_assoc_ies when rmmod >> 2eee3db784a0 wifi: brcmfmac: Fix to add skb free for TIM update info >> when tx is completed > > Thanks. Do you mind elaborating on why the 6th patch: > > brcmfmac: Update SSID of hidden AP while informing its bss to cfg8021= 1 layer > > was not applied? Because of mismatch between From and s-o-b. I will look at that in detail after my vacation. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes