From: Petr Machata <petrm@nvidia.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Petr Machata <petrm@nvidia.com>, <netdev@vger.kernel.org>,
Jiri Pirko <jiri@resnulli.us>,
Cong Wang <xiyou.wangcong@gmail.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, <komachi.yoshiki@gmail.com>,
Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
Subject: Re: [PATCH net] selftests: forwarding: Fix packet matching in mirroring selftests
Date: Wed, 10 Nov 2021 16:22:25 +0100 [thread overview]
Message-ID: <871r3oc9xq.fsf@nvidia.com> (raw)
In-Reply-To: <25844618-b63d-251b-f8e1-1f0c045b87f3@mojatatu.com>
Jamal Hadi Salim <jhs@mojatatu.com> writes:
> While it makes sense to look at outer header - every other script
> out in the wild (including your selftests) assumed inner header.
It didn't so much make assumptions as happened to work despite being
buggy. But yeah, fair point.
next prev parent reply other threads:[~2021-11-10 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 16:17 [PATCH net] selftests: forwarding: Fix packet matching in mirroring selftests Petr Machata
2021-11-10 14:39 ` Jamal Hadi Salim
2021-11-10 15:22 ` Petr Machata [this message]
2021-11-12 11:50 ` Jamal Hadi Salim
2021-11-10 14:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r3oc9xq.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=komachi.yoshiki@gmail.com \
--cc=kuba@kernel.org \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).