From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19BA7C2BBCA for ; Wed, 16 Dec 2020 13:22:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9AAC233CF for ; Wed, 16 Dec 2020 13:22:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726347AbgLPNWX (ORCPT ); Wed, 16 Dec 2020 08:22:23 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:54634 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726333AbgLPNWX (ORCPT ); Wed, 16 Dec 2020 08:22:23 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1608124917; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=dlbrynf84dvX8jOV45UJ087GRtlBhIoPyp1S27UWkAI=; b=hFVctFmdnudZyQNrZs8S+G7mNR34jdHVJgYAriUi+RvGtNuc+CTKmup/1Zu70OnHF9Itj4uB CyItK7eOnncGAsBC85enBGRX87KjFz9PPDOMWeA/yowMBDl2/b6CSAmMzm774UpIoTymR80D jdzhsLnErdINp7qOYKiyKY0xt10= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 5fda09d80564dfefcdabbbdd (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 16 Dec 2020 13:21:28 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 4A2AFC433ED; Wed, 16 Dec 2020 13:21:28 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3C2A7C433CA; Wed, 16 Dec 2020 13:21:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3C2A7C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Zheng Yongjun Cc: , , , , , , , Subject: Re: [PATCH wireless -next] brcmfmac: Delete useless kfree code References: <20201216130350.13815-1-zhengyongjun3@huawei.com> Date: Wed, 16 Dec 2020 15:21:23 +0200 In-Reply-To: <20201216130350.13815-1-zhengyongjun3@huawei.com> (Zheng Yongjun's message of "Wed, 16 Dec 2020 21:03:50 +0800") Message-ID: <871rfpyjho.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Zheng Yongjun writes: > The parameter of kfree function is NULL, so kfree code is useless, delete it. > Therefore, goto expression is no longer needed, so simplify it. > > Signed-off-by: Zheng Yongjun > --- > .../net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) You forgot to CC linux-wireless, please resend as v2 -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches